Re: [FFmpeg-devel] [PATCH 2/4] h264_mp4toannexb_bsf: Improve extradata overread checks

2019-07-24 Thread Andreas Rheinhardt
Michael Niedermayer: > On Mon, Jul 22, 2019 at 05:27:13AM +0200, Andreas Rheinhardt wrote: >> 1. Currently during parsing the extradata, h264_mp4toannexb checks for >> overreads by adding the size of the current unit to the current position >> pointer and comparing this to the end position of the e

Re: [FFmpeg-devel] [PATCH 2/4] h264_mp4toannexb_bsf: Improve extradata overread checks

2019-07-24 Thread Michael Niedermayer
On Mon, Jul 22, 2019 at 05:27:13AM +0200, Andreas Rheinhardt wrote: > 1. Currently during parsing the extradata, h264_mp4toannexb checks for > overreads by adding the size of the current unit to the current position > pointer and comparing this to the end position of the extradata. But > pointer co

[FFmpeg-devel] [PATCH 2/4] h264_mp4toannexb_bsf: Improve extradata overread checks

2019-07-21 Thread Andreas Rheinhardt
1. Currently during parsing the extradata, h264_mp4toannexb checks for overreads by adding the size of the current unit to the current position pointer and comparing this to the end position of the extradata. But pointer comparisons and pointer arithmetic is only defined if it does not exceed the o