Re: [FFmpeg-devel] [PATCH 2/4] dict.c: Add av_dict_set_int helper function.

2014-07-30 Thread Lukasz Marek
On 30.07.2014 23:16, Lukasz Marek wrote: +int av_dict_set_int(AVDictionary **pm, const char *key, int64_t value, +int flags) +{ +char valuestr[22]; +snprintf(valuestr, sizeof(valuestr), "%"PRId64, value); +return av_dict_set_int(pm, key, valuestr, flags); +} I gues

Re: [FFmpeg-devel] [PATCH 2/4] dict.c: Add av_dict_set_int helper function.

2014-07-30 Thread Lukasz Marek
+int av_dict_set_int(AVDictionary **pm, const char *key, int64_t value, +int flags) +{ +char valuestr[22]; +snprintf(valuestr, sizeof(valuestr), "%"PRId64, value); +return av_dict_set_int(pm, key, valuestr, flags); +} I guess it's infinite recurrence. ffplay crashes

Re: [FFmpeg-devel] [PATCH 2/4] dict.c: Add av_dict_set_int helper function.

2014-07-30 Thread Reimar Döffinger
On Wed, Jul 30, 2014 at 09:22:27PM +0200, wm4 wrote: > > /** > > @@ -123,6 +125,12 @@ int av_dict_count(const AVDictionary *m); > > int av_dict_set(AVDictionary **pm, const char *key, const char *value, int > > flags); > > > > /** > > + * Convenience wrapper for av_dict_set that converts the

Re: [FFmpeg-devel] [PATCH 2/4] dict.c: Add av_dict_set_int helper function.

2014-07-30 Thread wm4
On Wed, 30 Jul 2014 20:38:06 +0200 Reimar Döffinger wrote: > This allows getting rid of the many, slightly differing, implementations > of basically the same thing. > > Signed-off-by: Reimar Döffinger > --- > doc/APIchanges | 3 +++ > ffmpeg_opt.c | 12 ++

Re: [FFmpeg-devel] [PATCH 2/4] dict.c: Add av_dict_set_int helper function.

2014-07-30 Thread Reimar Döffinger
On Wed, Jul 30, 2014 at 08:38:06PM +0200, Reimar Döffinger wrote: > This allows getting rid of the many, slightly differing, implementations > of basically the same thing. This one really can need a few extra eyes. It's likely I missed a few places, and there's a risk I messed up one or the other

[FFmpeg-devel] [PATCH 2/4] dict.c: Add av_dict_set_int helper function.

2014-07-30 Thread Reimar Döffinger
This allows getting rid of the many, slightly differing, implementations of basically the same thing. Signed-off-by: Reimar Döffinger --- doc/APIchanges | 3 +++ ffmpeg_opt.c | 12 +++- ffplay.c | 2 +- libavfilter/vf_bbox.c