Re: [FFmpeg-devel] [PATCH 2/3] x86/ac3dsp: add ff_float_to_fixed24_avx2()

2023-11-23 Thread Henrik Gramner via ffmpeg-devel
On Thu, Nov 23, 2023 at 12:51 PM James Almer wrote: > movdqa wiht ymm is avx2. I could change it to movaps, but technically > the registers contain floats and i don't know if any old AVX cpu has > penalties for changing domains. Fwiw I believe what domain the result of fp <-> int conversion instr

Re: [FFmpeg-devel] [PATCH 2/3] x86/ac3dsp: add ff_float_to_fixed24_avx2()

2023-11-23 Thread James Almer
On 11/23/2023 3:56 AM, Kieran Kunhya wrote: On Wed, 22 Nov 2023, 19:49 James Almer, wrote: Signed-off-by: James Almer --- libavcodec/ac3dsp.h | 4 ++-- libavcodec/ac3enc_template.c | 2 +- libavcodec/x86/ac3dsp.asm| 28 ++-- libavcodec/x86/ac3dsp_in

Re: [FFmpeg-devel] [PATCH 2/3] x86/ac3dsp: add ff_float_to_fixed24_avx2()

2023-11-22 Thread Kieran Kunhya
On Wed, 22 Nov 2023, 19:49 James Almer, wrote: > Signed-off-by: James Almer > --- > libavcodec/ac3dsp.h | 4 ++-- > libavcodec/ac3enc_template.c | 2 +- > libavcodec/x86/ac3dsp.asm| 28 ++-- > libavcodec/x86/ac3dsp_init.c | 4 > 4 files changed, 33 i

[FFmpeg-devel] [PATCH 2/3] x86/ac3dsp: add ff_float_to_fixed24_avx2()

2023-11-22 Thread James Almer
Signed-off-by: James Almer --- libavcodec/ac3dsp.h | 4 ++-- libavcodec/ac3enc_template.c | 2 +- libavcodec/x86/ac3dsp.asm| 28 ++-- libavcodec/x86/ac3dsp_init.c | 4 4 files changed, 33 insertions(+), 5 deletions(-) diff --git a/libavcodec/ac3dsp.h