Re: [FFmpeg-devel] [PATCH 2/3] scale_cuda frame crop support

2024-10-18 Thread Koushik Dutta
I checked the crop filter and scale_vaapi implementation. The crop filter omits the requested crop width and height from the link, and expects the filter to know the final size ahead of time. So it seems the user is expected to provide the hardware scale filter with a final width and the height. sc

Re: [FFmpeg-devel] [PATCH 2/3] scale_cuda frame crop support

2024-10-18 Thread Koushik Dutta
I think the passthrough flag should be validated at filter processing time as well. Currently passthrough is checked at filter creation time, when only input/output sizes are available. During cudascale_filter_frame, the frame crop values should also be verified to determine if it is truly a no-op

Re: [FFmpeg-devel] [PATCH 2/3] scale_cuda frame crop support

2024-10-06 Thread Timo Rothenpieler
On 10.09.2024 20:10, Koushik Dutta wrote: The crop filter has no effect on scale_cuda: -vf crop=100:100,scale_cuda=300x300 Hardware frames (AV_PIX_FMT_FLAG_HWACCEL) are expected to use the crop_* properties, as seen in the implementation vf_crop.c. The current workaround is to hwdownload the

Re: [FFmpeg-devel] [PATCH 2/3] scale_cuda frame crop support

2024-09-10 Thread Timo Rothenpieler
On 10.09.2024 20:10, Koushik Dutta wrote: The crop filter has no effect on scale_cuda: -vf crop=100:100,scale_cuda=300x300 Hardware frames (AV_PIX_FMT_FLAG_HWACCEL) are expected to use the crop_* properties, as seen in the implementation vf_crop.c. The current workaround is to hwdownload the

[FFmpeg-devel] [PATCH 2/3] scale_cuda frame crop support

2024-09-10 Thread Koushik Dutta
The crop filter has no effect on scale_cuda: -vf crop=100:100,scale_cuda=300x300 Hardware frames (AV_PIX_FMT_FLAG_HWACCEL) are expected to use the crop_* properties, as seen in the implementation vf_crop.c. The current workaround is to hwdownload the full frame and perform the crop on CPU. ---