Re: [FFmpeg-devel] [PATCH 2/3] mlvdec: validate bits_per_coded_sample

2015-12-22 Thread Andreas Cadhalpun
On 21.12.2015 02:18, Michael Niedermayer wrote: > On Sun, Dec 20, 2015 at 12:15:17PM +0100, Andreas Cadhalpun wrote: >> mlvdec.c | 12 >> 1 file changed, 12 insertions(+) >> 9870daae0ba6a9c826563645319ee38c694025e8 >> 0002-mlvdec-validate-bits_per_coded_sample.patch >> From 66a3af

Re: [FFmpeg-devel] [PATCH 2/3] mlvdec: validate bits_per_coded_sample

2015-12-20 Thread Michael Niedermayer
On Sun, Dec 20, 2015 at 12:15:17PM +0100, Andreas Cadhalpun wrote: > On 20.12.2015 00:55, Michael Niedermayer wrote: > > On Sat, Dec 19, 2015 at 11:49:02PM +0100, Andreas Cadhalpun wrote: > >> A negative bits_per_coded_sample doesn't make sense. > >> If it is too large, the size calculation for av_

Re: [FFmpeg-devel] [PATCH 2/3] mlvdec: validate bits_per_coded_sample

2015-12-20 Thread Andreas Cadhalpun
On 20.12.2015 00:55, Michael Niedermayer wrote: > On Sat, Dec 19, 2015 at 11:49:02PM +0100, Andreas Cadhalpun wrote: >> A negative bits_per_coded_sample doesn't make sense. >> If it is too large, the size calculation for av_get_packet overflows, >> resulting in allocation of a too small buffer. >>

Re: [FFmpeg-devel] [PATCH 2/3] mlvdec: validate bits_per_coded_sample

2015-12-19 Thread Peter Ross
On Sat, Dec 19, 2015 at 11:49:02PM +0100, Andreas Cadhalpun wrote: > A negative bits_per_coded_sample doesn't make sense. > If it is too large, the size calculation for av_get_packet overflows, > resulting in allocation of a too small buffer. > > Signed-off-by: Andreas Cadhalpun > --- > libavfor

Re: [FFmpeg-devel] [PATCH 2/3] mlvdec: validate bits_per_coded_sample

2015-12-19 Thread Michael Niedermayer
On Sat, Dec 19, 2015 at 11:49:02PM +0100, Andreas Cadhalpun wrote: > A negative bits_per_coded_sample doesn't make sense. > If it is too large, the size calculation for av_get_packet overflows, > resulting in allocation of a too small buffer. > > Signed-off-by: Andreas Cadhalpun > --- > libavfor

[FFmpeg-devel] [PATCH 2/3] mlvdec: validate bits_per_coded_sample

2015-12-19 Thread Andreas Cadhalpun
A negative bits_per_coded_sample doesn't make sense. If it is too large, the size calculation for av_get_packet overflows, resulting in allocation of a too small buffer. Signed-off-by: Andreas Cadhalpun --- libavformat/mlvdec.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavfo