Re: [FFmpeg-devel] [PATCH 2/3] lavc/libxvid: return meaningful error codes

2014-11-25 Thread Lukasz Marek
On 24.11.2014 05:00, Michael Niedermayer wrote: On Mon, Nov 24, 2014 at 04:14:06AM +0100, Lukasz Marek wrote: On 24.11.2014 03:07, Michael Niedermayer wrote: On Mon, Nov 24, 2014 at 01:17:29AM +0100, Lukasz Marek wrote: strictly, this should be errno when write returns -1, also av_log() might c

Re: [FFmpeg-devel] [PATCH 2/3] lavc/libxvid: return meaningful error codes

2014-11-23 Thread Michael Niedermayer
On Mon, Nov 24, 2014 at 04:14:06AM +0100, Lukasz Marek wrote: > On 24.11.2014 03:07, Michael Niedermayer wrote: > >On Mon, Nov 24, 2014 at 01:17:29AM +0100, Lukasz Marek wrote: > >>Signed-off-by: Lukasz Marek > >>--- > >> libavcodec/libxvid.c | 4 > >> 1 file changed, 4 insertions(+) > >> >

Re: [FFmpeg-devel] [PATCH 2/3] lavc/libxvid: return meaningful error codes

2014-11-23 Thread Lukasz Marek
On 24.11.2014 03:07, Michael Niedermayer wrote: On Mon, Nov 24, 2014 at 01:17:29AM +0100, Lukasz Marek wrote: Signed-off-by: Lukasz Marek --- libavcodec/libxvid.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/libxvid.c b/libavcodec/libxvid.c index 020af32..70d52b9 100644

Re: [FFmpeg-devel] [PATCH 2/3] lavc/libxvid: return meaningful error codes

2014-11-23 Thread Michael Niedermayer
On Mon, Nov 24, 2014 at 01:17:29AM +0100, Lukasz Marek wrote: > Signed-off-by: Lukasz Marek > --- > libavcodec/libxvid.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavcodec/libxvid.c b/libavcodec/libxvid.c > index 020af32..70d52b9 100644 > --- a/libavcodec/libxvid.c > +++ b/l

[FFmpeg-devel] [PATCH 2/3] lavc/libxvid: return meaningful error codes

2014-11-23 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- libavcodec/libxvid.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/libxvid.c b/libavcodec/libxvid.c index 020af32..70d52b9 100644 --- a/libavcodec/libxvid.c +++ b/libavcodec/libxvid.c @@ -488,6 +488,7 @@ static av_cold int xvid_encode_init(AVCo