Re: [FFmpeg-devel] [PATCH 2/3] cbs_h264: Improve performance of writing slices

2018-11-11 Thread Andreas Rheinhardt
I have created a new version that addresses all your concerns. Will send it in a moment. I actually wanted to make a separate function, but decided against it because the code already contained the duplication, so I thought that is how you liked it. Thanks for the review. Btw: What was the norma

Re: [FFmpeg-devel] [PATCH 2/3] cbs_h264: Improve performance of writing slices

2018-11-11 Thread Mark Thompson
On 04/11/18 04:48, Andreas Rheinhardt wrote: > Instead of using a combination of bitreader and -writer for copying data, > one can byte-align the (obsolete and removed) bitreader to improve > performance. > With the right alignment one can even use memcpy. The right alignment > normally exists for

[FFmpeg-devel] [PATCH 2/3] cbs_h264: Improve performance of writing slices

2018-11-03 Thread Andreas Rheinhardt
Instead of using a combination of bitreader and -writer for copying data, one can byte-align the (obsolete and removed) bitreader to improve performance. With the right alignment one can even use memcpy. The right alignment normally exists for CABAC. For aligned data this reduced the time to copy t