Re: [FFmpeg-devel] [PATCH 2/3] avcodec/videotoolboxenc: remove AUTO_PROFILE define

2023-06-24 Thread zhilizhao(赵志立)
> On Jun 24, 2023, at 17:21, Tomas Härdin wrote: > > fre 2023-06-09 klockan 19:14 +0800 skrev Zhao Zhili: >> From: Zhao Zhili >> >> Use FF_PROFILE_UNKNOWN as auto mode. > > Won't this break code that relies on AUTO_PROFILE? On the other hand If you mean that setting profile via the integer

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/videotoolboxenc: remove AUTO_PROFILE define

2023-06-24 Thread Tomas Härdin
fre 2023-06-09 klockan 19:14 +0800 skrev Zhao Zhili: > From: Zhao Zhili > > Use FF_PROFILE_UNKNOWN as auto mode. Won't this break code that relies on AUTO_PROFILE? On the other hand zero refers to profiles that actually exist such as profile0 for vp9, so the old behavior is kinda bad. /Tomas __

[FFmpeg-devel] [PATCH 2/3] avcodec/videotoolboxenc: remove AUTO_PROFILE define

2023-06-09 Thread Zhao Zhili
From: Zhao Zhili Use FF_PROFILE_UNKNOWN as auto mode. --- libavcodec/videotoolboxenc.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index 26485a3dea..9f65519700 100644 --- a/libavcodec/videotoolboxenc.