Re: [FFmpeg-devel] [PATCH 2/3] avcodec/rv60: RealVideo 6.0 decoder

2024-03-02 Thread Andreas Rheinhardt
Peter Ross: > Reviewed-by: Anton Khirnov > Reviewed-by: Andreas Rheinhardt > Signed-off-by: Peter Ross > --- > libavcodec/Makefile |1 + > libavcodec/allcodecs.c |1 + > libavcodec/codec_desc.c |7 + > libavcodec/codec_id.h |1 + > libavcodec/rv60data.h | 118 ++ > lib

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/rv60: RealVideo 6.0 decoder

2023-10-23 Thread Peter Ross
On Mon, Oct 23, 2023 at 12:14:52PM +0200, Anton Khirnov wrote: > Quoting Peter Ross (2023-10-22 01:31:32) > > On Wed, Oct 18, 2023 at 04:42:01PM +0200, Anton Khirnov wrote: > > > Quoting Peter Ross (2023-10-18 10:03:54) > > [..] > > > I think you can simplify this into: > > > if (s->last_frame[

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/rv60: RealVideo 6.0 decoder

2023-10-23 Thread Anton Khirnov
Quoting Peter Ross (2023-10-22 01:31:32) > On Wed, Oct 18, 2023 at 04:42:01PM +0200, Anton Khirnov wrote: > > Quoting Peter Ross (2023-10-18 10:03:54) > [..] > > I think you can simplify this into: > > if (s->last_frame[NEXT_PIC]->data[0]) { > > av_frame_move_ref(frame, s->last_frame[NE

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/rv60: RealVideo 6.0 decoder

2023-10-23 Thread Peter Ross
On Sun, Oct 22, 2023 at 03:37:34PM +0200, Andreas Rheinhardt wrote: > Peter Ross: > > --- > > diff --git a/libavformat/matroska.c b/libavformat/matroska.c > > index 5878594e68..1674806f29 100644 > > --- a/libavformat/matroska.c > > +++ b/libavformat/matroska.c > > @@ -95,6 +95,7 @@ const CodecTags

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/rv60: RealVideo 6.0 decoder

2023-10-22 Thread Andreas Rheinhardt
Peter Ross: > --- > diff --git a/libavformat/matroska.c b/libavformat/matroska.c > index 5878594e68..1674806f29 100644 > --- a/libavformat/matroska.c > +++ b/libavformat/matroska.c > @@ -95,6 +95,7 @@ const CodecTags ff_mkv_codec_tags[]={ > {"V_REAL/RV20" , AV_CODEC_ID_RV20}, > {"V_R

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/rv60: RealVideo 6.0 decoder

2023-10-21 Thread Peter Ross
On Wed, Oct 18, 2023 at 04:42:01PM +0200, Anton Khirnov wrote: > Quoting Peter Ross (2023-10-18 10:03:54) [..] > I think you can simplify this into: > if (s->last_frame[NEXT_PIC]->data[0]) { > av_frame_move_ref(frame, s->last_frame[NEXT_PIC]); > *got_frame = 1; > } [..] > Yo

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/rv60: RealVideo 6.0 decoder

2023-10-18 Thread Anton Khirnov
Quoting Peter Ross (2023-10-18 10:03:54) > +static int rv60_decode_frame(AVCodecContext *avctx, AVFrame * frame, > + int * got_frame, AVPacket * avpkt) > +{ > +RV60Context *s = avctx->priv_data; > +GetBitContext gb; > +int ret, header_size, width, height, ofs