Re: [FFmpeg-devel] [PATCH 2/2] libswcale/input: fix incorrect rgbf32 yuv conversions

2020-09-28 Thread Mark Reid
On Mon, Sep 28, 2020 at 10:38 AM Michael Niedermayer wrote: > On Sat, Sep 26, 2020 at 10:01:30PM -0700, Mark Reid wrote: > > On Mon, Sep 14, 2020 at 6:31 PM Mark Reid wrote: > > > > > > > > > > > On Mon, Sep 14, 2020 at 2:44 PM Michael Niedermayer > > > > wrote: > > > > > >> On Sun, Sep 13, 202

Re: [FFmpeg-devel] [PATCH 2/2] libswcale/input: fix incorrect rgbf32 yuv conversions

2020-09-28 Thread Michael Niedermayer
On Sat, Sep 26, 2020 at 10:01:30PM -0700, Mark Reid wrote: > On Mon, Sep 14, 2020 at 6:31 PM Mark Reid wrote: > > > > > > > On Mon, Sep 14, 2020 at 2:44 PM Michael Niedermayer > > wrote: > > > >> On Sun, Sep 13, 2020 at 04:04:42PM -0700, Mark Reid wrote: > >> > On Sun, Sep 13, 2020 at 8:55 AM Mi

Re: [FFmpeg-devel] [PATCH 2/2] libswcale/input: fix incorrect rgbf32 yuv conversions

2020-09-28 Thread Michael Niedermayer
On Sat, Sep 26, 2020 at 10:01:30PM -0700, Mark Reid wrote: > On Mon, Sep 14, 2020 at 6:31 PM Mark Reid wrote: > > > > > > > On Mon, Sep 14, 2020 at 2:44 PM Michael Niedermayer > > wrote: > > > >> On Sun, Sep 13, 2020 at 04:04:42PM -0700, Mark Reid wrote: > >> > On Sun, Sep 13, 2020 at 8:55 AM Mi

Re: [FFmpeg-devel] [PATCH 2/2] libswcale/input: fix incorrect rgbf32 yuv conversions

2020-09-26 Thread Mark Reid
On Mon, Sep 14, 2020 at 6:31 PM Mark Reid wrote: > > > On Mon, Sep 14, 2020 at 2:44 PM Michael Niedermayer > wrote: > >> On Sun, Sep 13, 2020 at 04:04:42PM -0700, Mark Reid wrote: >> > On Sun, Sep 13, 2020 at 8:55 AM Michael Niedermayer >> >> > wrote: >> > >> > > On Sat, Sep 12, 2020 at 02:07:1

Re: [FFmpeg-devel] [PATCH 2/2] libswcale/input: fix incorrect rgbf32 yuv conversions

2020-09-14 Thread Mark Reid
On Mon, Sep 14, 2020 at 2:44 PM Michael Niedermayer wrote: > On Sun, Sep 13, 2020 at 04:04:42PM -0700, Mark Reid wrote: > > On Sun, Sep 13, 2020 at 8:55 AM Michael Niedermayer > > > wrote: > > > > > On Sat, Sep 12, 2020 at 02:07:14AM -0700, mindm...@gmail.com wrote: > > > > From: Mark Reid > >

Re: [FFmpeg-devel] [PATCH 2/2] libswcale/input: fix incorrect rgbf32 yuv conversions

2020-09-14 Thread Michael Niedermayer
On Sun, Sep 13, 2020 at 04:04:42PM -0700, Mark Reid wrote: > On Sun, Sep 13, 2020 at 8:55 AM Michael Niedermayer > wrote: > > > On Sat, Sep 12, 2020 at 02:07:14AM -0700, mindm...@gmail.com wrote: > > > From: Mark Reid > > > > > > --- > > > libswscale/input.c | 12 +--- >

Re: [FFmpeg-devel] [PATCH 2/2] libswcale/input: fix incorrect rgbf32 yuv conversions

2020-09-14 Thread Rémi Achard
> The rgb48ToUV and rgb48ToY funcs in input.c use the formula I'm using. rgb64ToUV and rgb64ToY use it too, might be an opportunity to reduce code duplication. I ran into this while working on related precision issues (color range conversion being precise only for 8bits) and just used the same fo

Re: [FFmpeg-devel] [PATCH 2/2] libswcale/input: fix incorrect rgbf32 yuv conversions

2020-09-13 Thread Mark Reid
On Sun., Sep. 13, 2020, 4:04 p.m. Mark Reid, wrote: > > > On Sun, Sep 13, 2020 at 8:55 AM Michael Niedermayer > wrote: > >> On Sat, Sep 12, 2020 at 02:07:14AM -0700, mindm...@gmail.com wrote: >> > From: Mark Reid >> > >> > --- >> > libswscale/input.c | 12 +--- >> > te

Re: [FFmpeg-devel] [PATCH 2/2] libswcale/input: fix incorrect rgbf32 yuv conversions

2020-09-13 Thread Mark Reid
On Sun, Sep 13, 2020 at 8:55 AM Michael Niedermayer wrote: > On Sat, Sep 12, 2020 at 02:07:14AM -0700, mindm...@gmail.com wrote: > > From: Mark Reid > > > > --- > > libswscale/input.c | 12 +--- > > tests/ref/fate/filter-pixfmts-scale | 8 > > 2 files changed,

Re: [FFmpeg-devel] [PATCH 2/2] libswcale/input: fix incorrect rgbf32 yuv conversions

2020-09-13 Thread Michael Niedermayer
On Sat, Sep 12, 2020 at 02:07:14AM -0700, mindm...@gmail.com wrote: > From: Mark Reid > > --- > libswscale/input.c | 12 +--- > tests/ref/fate/filter-pixfmts-scale | 8 > 2 files changed, 9 insertions(+), 11 deletions(-) Can you provide some tests that show th

[FFmpeg-devel] [PATCH 2/2] libswcale/input: fix incorrect rgbf32 yuv conversions

2020-09-12 Thread mindmark
From: Mark Reid --- libswscale/input.c | 12 +--- tests/ref/fate/filter-pixfmts-scale | 8 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/libswscale/input.c b/libswscale/input.c index 064ed5902f..67a85b0418 100644 --- a/libswscale/input.c +++ b