Re: [FFmpeg-devel] [PATCH 2/2] libfdk-aacdec: Flush delayed samples at the end

2022-02-03 Thread Martin Storsjö
On Fri, 21 Jan 2022, Andreas Rheinhardt wrote: Interesting: There is indeed a delay at the start (720 samples in a quick test) compared to the native AAC decoder. Furthermore, the current code is buggy, as it believes that avcodec->time_base to be the time_base of the returned AVFrames (it is in

Re: [FFmpeg-devel] [PATCH 2/2] libfdk-aacdec: Flush delayed samples at the end

2022-01-21 Thread Andreas Rheinhardt
Martin Storsjö: > On Fri, 21 Jan 2022, Andreas Rheinhardt wrote: > >> Martin Storsjö: >>> Also trim off delay samples at the start instead of adjusting pts >>> to compensate for them; this avoids unwanted offsets if working >>> with raw samples without considering their pts. >>> --- >>>  libavcode

Re: [FFmpeg-devel] [PATCH 2/2] libfdk-aacdec: Flush delayed samples at the end

2022-01-21 Thread Martin Storsjö
On Fri, 21 Jan 2022, Andreas Rheinhardt wrote: Martin Storsjö: Also trim off delay samples at the start instead of adjusting pts to compensate for them; this avoids unwanted offsets if working with raw samples without considering their pts. --- libavcodec/libfdk-aacdec.c | 80 +

Re: [FFmpeg-devel] [PATCH 2/2] libfdk-aacdec: Flush delayed samples at the end

2022-01-21 Thread Andreas Rheinhardt
Martin Storsjö: > Also trim off delay samples at the start instead of adjusting pts > to compensate for them; this avoids unwanted offsets if working > with raw samples without considering their pts. > --- > libavcodec/libfdk-aacdec.c | 80 +++--- > 1 file changed,

[FFmpeg-devel] [PATCH 2/2] libfdk-aacdec: Flush delayed samples at the end

2022-01-19 Thread Martin Storsjö
Also trim off delay samples at the start instead of adjusting pts to compensate for them; this avoids unwanted offsets if working with raw samples without considering their pts. --- libavcodec/libfdk-aacdec.c | 80 +++--- 1 file changed, 65 insertions(+), 15 deletio