Re: [FFmpeg-devel] [PATCH 2/2] libavformat/takdec.c: Fix msan error.

2025-04-21 Thread Thierry Foucu
On Mon, Apr 21, 2025 at 10:01 AM Nicolas George wrote: > Thierry Foucu (HE12025-04-21): > > > >> -avio_read(pb, md5, 16); > > > >> +if (avio_read(pb, md5, 16) != 16) { > > > >> +return AVERROR(EIO); > > > Should be AVERROR_INVALIDDATA imo, since i means the

Re: [FFmpeg-devel] [PATCH 2/2] libavformat/takdec.c: Fix msan error.

2025-04-21 Thread Nicolas George
Thierry Foucu (HE12025-04-21): > > >> -avio_read(pb, md5, 16); > > >> +if (avio_read(pb, md5, 16) != 16) { > > >> +return AVERROR(EIO); > > Should be AVERROR_INVALIDDATA imo, since i means the file is just > > truncated. It wasn't an error in the protocol rea

Re: [FFmpeg-devel] [PATCH 2/2] libavformat/takdec.c: Fix msan error.

2025-04-21 Thread Thierry Foucu
Thanks James On Thu, Apr 17, 2025 at 1:25 PM James Almer wrote: > On 4/17/2025 4:08 PM, Thierry Foucu wrote: > > On Mon, Apr 7, 2025 at 11:10 AM wrote: > > > >> From: Thierry Foucu > >> > >> Make sure we are reading 16 bytes for the MD5 > >> --- > >> libavformat/takdec.c | 5 - > >> 1 f

Re: [FFmpeg-devel] [PATCH 2/2] libavformat/takdec.c: Fix msan error.

2025-04-17 Thread James Almer
On 4/17/2025 4:08 PM, Thierry Foucu wrote: On Mon, Apr 7, 2025 at 11:10 AM wrote: From: Thierry Foucu Make sure we are reading 16 bytes for the MD5 --- libavformat/takdec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/takdec.c b/libavformat/takdec.c

Re: [FFmpeg-devel] [PATCH 2/2] libavformat/takdec.c: Fix msan error.

2025-04-17 Thread Thierry Foucu
On Mon, Apr 7, 2025 at 11:10 AM wrote: > From: Thierry Foucu > > Make sure we are reading 16 bytes for the MD5 > --- > libavformat/takdec.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavformat/takdec.c b/libavformat/takdec.c > index 21fff3fcbf..61b9f001c4 100