Re: [FFmpeg-devel] [PATCH 2/2] lavf/movenc: sort options by name

2024-01-07 Thread Gyan Doshi
On 2024-01-08 08:23 am, Zhao Zhili wrote: On Jan 7, 2024, at 20:05, Stefano Sabatini wrote: On date Sunday 2024-01-07 13:10:44 +0800, Zhao Zhili wrote: [...] I'm not blocking the patch, however, I'm not sure whether the gain outweighs the effort for such large code changes. It's very unli

Re: [FFmpeg-devel] [PATCH 2/2] lavf/movenc: sort options by name

2024-01-07 Thread Zhao Zhili
> On Jan 7, 2024, at 20:05, Stefano Sabatini wrote: > > On date Sunday 2024-01-07 13:10:44 +0800, Zhao Zhili wrote: > [...] >> I'm not blocking the patch, however, I'm not sure whether the gain >> outweighs the effort for such large code changes. It's very >> unlikely to introduce new issues,

Re: [FFmpeg-devel] [PATCH 2/2] lavf/movenc: sort options by name

2024-01-07 Thread Stefano Sabatini
On date Sunday 2024-01-07 13:10:44 +0800, Zhao Zhili wrote: [...] > I'm not blocking the patch, however, I'm not sure whether the gain > outweighs the effort for such large code changes. It's very > unlikely to introduce new issues, but possible (e.g., typo while do > copy paste), and it's hard t

Re: [FFmpeg-devel] [PATCH 2/2] lavf/movenc: sort options by name

2024-01-06 Thread Zhao Zhili
> -Original Message- > From: ffmpeg-devel On Behalf Of Stefano > Sabatini > Sent: 2024年1月7日 0:53 > To: FFmpeg development discussions and patches > Cc: Stefano Sabatini > Subject: [FFmpeg-devel] [PATCH 2/2] lavf/movenc: sort options by name > > --- &

[FFmpeg-devel] [PATCH 2/2] lavf/movenc: sort options by name

2024-01-06 Thread Stefano Sabatini
--- libavformat/movenc.c | 86 ++-- 1 file changed, 43 insertions(+), 43 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 6b1ff408c7..c95410f5c1 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -70,56 +70,56 @@ #in