Re: [FFmpeg-devel] [PATCH 2/2] lavc: add h264 mediacodec decoder

2016-03-07 Thread Matthieu Bouron
On Thu, Mar 03, 2016 at 02:03:01PM +0100, Matthieu Bouron wrote: [...] > > Patch updated with the following differences: > * ff_set_dimensions return code is now used > * add missing exception when trying to call the MediaCodec object > constructor > * remove leftover avctx_internal field

Re: [FFmpeg-devel] [PATCH 2/2] lavc: add h264 mediacodec decoder

2016-03-03 Thread Matthieu Bouron
On Wed, Mar 02, 2016 at 03:34:09PM +0100, Matthieu Bouron wrote: > On Tue, Mar 01, 2016 at 11:26:45PM +0100, Michael Niedermayer wrote: > > On Tue, Mar 01, 2016 at 08:01:45PM +0100, Matthieu Bouron wrote: > > > On Sat, Feb 27, 2016 at 04:28:43PM +0100, Michael Niedermayer wrote: > > > > On Fri, Feb

Re: [FFmpeg-devel] [PATCH 2/2] lavc: add h264 mediacodec decoder

2016-03-02 Thread Matthieu Bouron
On Tue, Mar 01, 2016 at 11:26:45PM +0100, Michael Niedermayer wrote: > On Tue, Mar 01, 2016 at 08:01:45PM +0100, Matthieu Bouron wrote: > > On Sat, Feb 27, 2016 at 04:28:43PM +0100, Michael Niedermayer wrote: > > > On Fri, Feb 26, 2016 at 04:54:47PM +0100, Matthieu Bouron wrote: > > > > On Tue, Feb

Re: [FFmpeg-devel] [PATCH 2/2] lavc: add h264 mediacodec decoder

2016-03-01 Thread Michael Niedermayer
On Tue, Mar 01, 2016 at 08:01:45PM +0100, Matthieu Bouron wrote: > On Sat, Feb 27, 2016 at 04:28:43PM +0100, Michael Niedermayer wrote: > > On Fri, Feb 26, 2016 at 04:54:47PM +0100, Matthieu Bouron wrote: > > > On Tue, Feb 23, 2016 at 11:28:01AM +0100, wm4 wrote: > > > > On Tue, 23 Feb 2016 09:53:4

Re: [FFmpeg-devel] [PATCH 2/2] lavc: add h264 mediacodec decoder

2016-03-01 Thread Matthieu Bouron
On Sat, Feb 27, 2016 at 04:28:43PM +0100, Michael Niedermayer wrote: > On Fri, Feb 26, 2016 at 04:54:47PM +0100, Matthieu Bouron wrote: > > On Tue, Feb 23, 2016 at 11:28:01AM +0100, wm4 wrote: > > > On Tue, 23 Feb 2016 09:53:43 +0100 > > > Matthieu Bouron wrote: > > > > > > > On Mon, Feb 22, 2016

Re: [FFmpeg-devel] [PATCH 2/2] lavc: add h264 mediacodec decoder

2016-02-27 Thread Michael Niedermayer
On Fri, Feb 26, 2016 at 04:54:47PM +0100, Matthieu Bouron wrote: > On Tue, Feb 23, 2016 at 11:28:01AM +0100, wm4 wrote: > > On Tue, 23 Feb 2016 09:53:43 +0100 > > Matthieu Bouron wrote: > > > > > On Mon, Feb 22, 2016 at 01:08:49PM +0100, Michael Niedermayer wrote: > > > > On Mon, Feb 22, 2016 at

Re: [FFmpeg-devel] [PATCH 2/2] lavc: add h264 mediacodec decoder

2016-02-26 Thread Matthieu Bouron
On Fri, Feb 26, 2016 at 5:02 PM, Carl Eugen Hoyos wrote: > Matthieu Bouron gmail.com> writes: > > > Patch updated > > > + --enable-mediacodec enable Android MediaCodec support [no] > > > +enabled mediacodec&& { enabled jni || die > > Sorry if you have already explained: > Why are t

Re: [FFmpeg-devel] [PATCH 2/2] lavc: add h264 mediacodec decoder

2016-02-26 Thread Carl Eugen Hoyos
Matthieu Bouron gmail.com> writes: > Patch updated > + --enable-mediacodec enable Android MediaCodec support [no] > +enabled mediacodec&& { enabled jni || die Sorry if you have already explained: Why are two separate enable-options necessary? How is jni useful without mediacodec?

Re: [FFmpeg-devel] [PATCH 2/2] lavc: add h264 mediacodec decoder

2016-02-26 Thread Matthieu Bouron
On Tue, Feb 23, 2016 at 11:28:01AM +0100, wm4 wrote: > On Tue, 23 Feb 2016 09:53:43 +0100 > Matthieu Bouron wrote: > > > On Mon, Feb 22, 2016 at 01:08:49PM +0100, Michael Niedermayer wrote: > > > On Mon, Feb 22, 2016 at 12:20:36PM +0100, Matthieu Bouron wrote: > > > > From: Matthieu Bouron >

Re: [FFmpeg-devel] [PATCH 2/2] lavc: add h264 mediacodec decoder

2016-02-23 Thread wm4
On Mon, 22 Feb 2016 12:20:36 +0100 Matthieu Bouron wrote: > From: Matthieu Bouron > > --- > +FFAMediaFormat *ff_AMediaFormat_new() > +{ > +int attached = 0; That's C++, not C. In C it needs to be *ff_AMediaFormat_new(void). An empty argument list means that the argument list is unknown a

Re: [FFmpeg-devel] [PATCH 2/2] lavc: add h264 mediacodec decoder

2016-02-23 Thread wm4
On Tue, 23 Feb 2016 10:21:10 +0100 Matthieu Bouron wrote: > On Mon, Feb 22, 2016 at 02:55:06PM +0100, wm4 wrote: > > On Mon, 22 Feb 2016 12:20:36 +0100 > > Matthieu Bouron wrote: > > > > > From: Matthieu Bouron > > > > > > --- > > > ... > > > > Some remarks: > > > > - The qcom stuff sho

Re: [FFmpeg-devel] [PATCH 2/2] lavc: add h264 mediacodec decoder

2016-02-23 Thread wm4
On Tue, 23 Feb 2016 09:53:43 +0100 Matthieu Bouron wrote: > On Mon, Feb 22, 2016 at 01:08:49PM +0100, Michael Niedermayer wrote: > > On Mon, Feb 22, 2016 at 12:20:36PM +0100, Matthieu Bouron wrote: > > > From: Matthieu Bouron > > [...] > > > +codec = (*env)->NewObject(env, jfields.

Re: [FFmpeg-devel] [PATCH 2/2] lavc: add h264 mediacodec decoder

2016-02-23 Thread Matthieu Bouron
On Mon, Feb 22, 2016 at 02:55:06PM +0100, wm4 wrote: > On Mon, 22 Feb 2016 12:20:36 +0100 > Matthieu Bouron wrote: > > > From: Matthieu Bouron > > > > --- > > ... > > Some remarks: > > - The qcom stuff should probably be moved into its own source file, > because it's a lot of code, but self

Re: [FFmpeg-devel] [PATCH 2/2] lavc: add h264 mediacodec decoder

2016-02-23 Thread Matthieu Bouron
On Mon, Feb 22, 2016 at 01:08:49PM +0100, Michael Niedermayer wrote: > On Mon, Feb 22, 2016 at 12:20:36PM +0100, Matthieu Bouron wrote: > > From: Matthieu Bouron > [...] > > +codec = (*env)->NewObject(env, jfields.mediacodec_list_class, > > jfields.init_id, 0); > > +if (!codec) {

Re: [FFmpeg-devel] [PATCH 2/2] lavc: add h264 mediacodec decoder

2016-02-22 Thread wm4
On Mon, 22 Feb 2016 12:20:36 +0100 Matthieu Bouron wrote: > From: Matthieu Bouron > > --- > ... Some remarks: - The qcom stuff should probably be moved into its own source file, because it's a lot of code, but self-contained. - Do you really need h264_extradata_to_annexb_sps_pps? The BSF a

Re: [FFmpeg-devel] [PATCH 2/2] lavc: add h264 mediacodec decoder

2016-02-22 Thread Michael Niedermayer
On Mon, Feb 22, 2016 at 12:20:36PM +0100, Matthieu Bouron wrote: > From: Matthieu Bouron [...] > +codec = (*env)->NewObject(env, jfields.mediacodec_list_class, > jfields.init_id, 0); > +if (!codec) { > +av_log(NULL, AV_LOG_ERROR, "Could not create media codec > list\n

[FFmpeg-devel] [PATCH 2/2] lavc: add h264 mediacodec decoder

2016-02-22 Thread Matthieu Bouron
From: Matthieu Bouron --- configure |5 + libavcodec/Makefile |3 + libavcodec/allcodecs.c |1 + libavcodec/mediacodec_wrapper.c | 1521 +++ libavcodec/mediacodec_wrapper.h | 123 libavcodec/mediacod