Re: [FFmpeg-devel] [PATCH 2/2] lavc/libaomenc: Support lossless encoding

2020-04-05 Thread Ryo Hirafuji
Lynne, could you tell me your idea? 2020年4月5日(日) 19:39 Ryo Hirafuji : > > I would prefer this but I am not the maintainer. > > Oh, I see. > > Hi, Rostislav Pehlivanov, please tell me your idea. > (How can I address him/her in ML...?) > > I think it is more useful to execute this line when "-crf 0

Re: [FFmpeg-devel] [PATCH 2/2] lavc/libaomenc: Support lossless encoding

2020-04-05 Thread Ryo Hirafuji
> I would prefer this but I am not the maintainer. Oh, I see. Hi, Rostislav Pehlivanov, please tell me your idea. (How can I address him/her in ML...?) I think it is more useful to execute this line when "-crf 0" is set: > codecctl_int(avctx, AV1E_SET_LOSSLESS, ctx->lossless); It could let use

Re: [FFmpeg-devel] [PATCH 2/2] lavc/libaomenc: Support lossless encoding

2020-04-05 Thread Carl Eugen Hoyos
Am Sa., 4. Apr. 2020 um 18:46 Uhr schrieb Ryo Hirafuji : > > > In an ideal world, crf 0 would force all other settings for a lossless > > encoding. > > I forgot to say that if "-lossless 1" is set, "crf" will also be 0 (in > libaom, internally). > > All those conditions will be forced (ot at least

Re: [FFmpeg-devel] [PATCH 2/2] lavc/libaomenc: Support lossless encoding

2020-04-04 Thread Ryo Hirafuji
> In an ideal world, crf 0 would force all other settings for a lossless encoding. I forgot to say that if "-lossless 1" is set, "crf" will also be 0 (in libaom, internally). All those conditions will be forced (ot at least checked by libaom) if we execute this line: > codecctl_int(avctx, AV1E_S

Re: [FFmpeg-devel] [PATCH 2/2] lavc/libaomenc: Support lossless encoding

2020-04-04 Thread Carl Eugen Hoyos
Am Sa., 4. Apr. 2020 um 13:17 Uhr schrieb Ryo Hirafuji : > > > So "crf 0" already has a meaning different from all other crf values? > > No. "crf 0" has the same meanings. It just makes the quality better than > "crf 1". That was my question, sorry for being unclear. > I read libaom again, and I

Re: [FFmpeg-devel] [PATCH 2/2] lavc/libaomenc: Support lossless encoding

2020-04-04 Thread Ryo Hirafuji
> So "crf 0" already has a meaning different from all other crf values? No. "crf 0" has the same meanings. It just makes the quality better than "crf 1". I read libaom again, and I apologize for my wrong explanation: I found that if certain conditions are met, "crf 0" also generates lossless vi

Re: [FFmpeg-devel] [PATCH 2/2] lavc/libaomenc: Support lossless encoding

2020-04-04 Thread Carl Eugen Hoyos
Am Sa., 4. Apr. 2020 um 12:16 Uhr schrieb Ryo Hirafuji : > > > Is it possible to use "cfr 0" instead? > > Unfortunately, crf=0 is not lossless. > "lossless" flag uses "quantisation matrices", which is different from the > default quantizer determined by "-crf", to achieve lossless encoding. So "cr

Re: [FFmpeg-devel] [PATCH 2/2] lavc/libaomenc: Support lossless encoding

2020-04-04 Thread Ryo Hirafuji
> Is it possible to use "cfr 0" instead? Unfortunately, crf=0 is not lossless. "lossless" flag uses "quantisation matrices", which is different from the default quantizer determined by "-crf", to achieve lossless encoding. 2020年4月4日(土) 18:59 Carl Eugen Hoyos : > Am Sa., 4. Apr. 2020 um 11:57 Uh

[FFmpeg-devel] [PATCH 2/2] lavc/libaomenc: Support lossless encoding

2020-04-04 Thread Ryo Hirafuji
From: Ryo Hirafuji AV1 support lossless encoding. In this patch, I added a command line flag to enable it. --- libavcodec/libaomenc.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index fb61ce82e2..4a7f4b662a 100

Re: [FFmpeg-devel] [PATCH 2/2] lavc/libaomenc: Support lossless encoding

2020-04-04 Thread Carl Eugen Hoyos
Am Sa., 4. Apr. 2020 um 11:57 Uhr schrieb Ryo Hirafuji : > > From: Ryo Hirafuji > > AV1 support lossless encoding. > In this patch, I added a command line flag to enable it. > > --- > libavcodec/libaomenc.c | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/liba

[FFmpeg-devel] [PATCH 2/2] lavc/libaomenc: Support lossless encoding

2020-04-04 Thread Ryo Hirafuji
From: Ryo Hirafuji AV1 support lossless encoding. In this patch, I added a command line flag to enable it. --- libavcodec/libaomenc.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index fb61ce82e2..4a7f4b662a 100