Re: [FFmpeg-devel] [PATCH 2/2] dirac: implement a native Dirac HQ encoder

2016-01-26 Thread Carl Eugen Hoyos
Rostislav Pehlivanov gmail.com> writes: > This commit adds a new encoder capable of creating > BBC Dirac VC-2 HQ profile files. Shouldn't the short name of this encoder be "vc2" while a future encoder with non-I frames would be called "dirac"? > + * Copyright (C) 2016 Open Broadcast Systems L

Re: [FFmpeg-devel] [PATCH 2/2] dirac: implement a native Dirac HQ encoder

2016-01-23 Thread Rostislav Pehlivanov
>This seems to partially duplicate the dwt_type enum in dirac_dwt.h >Maybe you could share all this dwt code from both decoder and encoder >in some way? I could move the enum to the dirac.h file, but I don't really want to #include that into the transforms files and have it include avcodec.h and w

Re: [FFmpeg-devel] [PATCH 2/2] dirac: implement a native Dirac HQ encoder

2016-01-23 Thread James Almer
On 1/22/2016 3:15 PM, Rostislav Pehlivanov wrote: > diff --git a/libavcodec/diracenc_transforms.h > b/libavcodec/diracenc_transforms.h > new file mode 100644 > index 000..3b723b2 > --- /dev/null > +++ b/libavcodec/diracenc_transforms.h > @@ -0,0 +1,53 @@ > +/* > + * Copyright (C) 2016 Open Bro

[FFmpeg-devel] [PATCH 2/2] dirac: implement a native Dirac HQ encoder

2016-01-22 Thread Rostislav Pehlivanov
Changes from the first vesion: - Support 100% of the specifications. - Enable 5 level transforms and custom quantization matrices. - Raise the max slice size limit to 1024x1024 (works & supported) - Change default settings to 5 level transforms with 128x64 slices - Share tables