Re: [FFmpeg-devel] [PATCH 2/2] configure: Use -fno-sanitize-recover

2025-01-17 Thread James Almer
On 1/17/2025 8:27 PM, Vitaly Buka via ffmpeg-devel wrote: On Fri, Jan 17, 2025 at 3:12 PM James Almer wrote: On 1/17/2025 7:53 PM, Vitaly Buka via ffmpeg-devel wrote: My confusion here is that it looks like ffmpeg developers care about UB, I see from time to time large cleanups, but there a

Re: [FFmpeg-devel] [PATCH 2/2] configure: Use -fno-sanitize-recover

2025-01-17 Thread Vitaly Buka via ffmpeg-devel
On Fri, Jan 17, 2025 at 3:12 PM James Almer wrote: > On 1/17/2025 7:53 PM, Vitaly Buka via ffmpeg-devel wrote: > > My confusion here is that it looks like ffmpeg developers care about UB, > I > > see from time to time large cleanups, but there are a bunch of unfixed > > reports. > > Maybe forcing

Re: [FFmpeg-devel] [PATCH 2/2] configure: Use -fno-sanitize-recover

2025-01-17 Thread James Almer
On 1/17/2025 7:53 PM, Vitaly Buka via ffmpeg-devel wrote: My confusion here is that it looks like ffmpeg developers care about UB, I see from time to time large cleanups, but there are a bunch of unfixed reports. Maybe forcing no-recover by default will improve this situation? It will not chang

Re: [FFmpeg-devel] [PATCH 2/2] configure: Use -fno-sanitize-recover

2025-01-17 Thread Vitaly Buka via ffmpeg-devel
My confusion here is that it looks like ffmpeg developers care about UB, I see from time to time large cleanups, but there are a bunch of unfixed reports. Maybe forcing no-recover by default will improve this situation? On Fri, Jan 17, 2025 at 11:57 AM Frank Plowman wrote: > On 16/01/2025 19:12

Re: [FFmpeg-devel] [PATCH 2/2] configure: Use -fno-sanitize-recover

2025-01-17 Thread Frank Plowman
On 16/01/2025 19:12, Vitaly Buka via ffmpeg-devel wrote: > UBSAN by default is just prints a mesage and > moves on. This hides a few UBs in fate-suite. > > Signed-off-by: Vitaly Buka > --- > configure | 4 ++-- > libavcodec/aacenc_pred.c | 1 + > libavcodec/ffv1dec.c

Re: [FFmpeg-devel] [PATCH 2/2] configure: Use -fno-sanitize-recover

2025-01-16 Thread Vitaly Buka via ffmpeg-devel
I assume "recover" mode is there unintentionally. "-fno-sanitize-recover" helps to keep the code clean. On Thu, Jan 16, 2025 at 11:13 AM Vitaly Buka wrote: > UBSAN by default is just prints a mesage and > moves on. This hides a few UBs in fate-suite. > > Signed-off-by: Vitaly Buka > --- > conf

Re: [FFmpeg-devel] [PATCH 2/2] configure: Use -fno-sanitize-recover

2025-01-16 Thread James Almer
On 1/16/2025 4:12 PM, Vitaly Buka via ffmpeg-devel wrote: UBSAN by default is just prints a mesage and moves on. This hides a few UBs in fate-suite. Signed-off-by: Vitaly Buka --- configure | 4 ++-- libavcodec/aacenc_pred.c | 1 + libavcodec/ffv1dec.c | 1

[FFmpeg-devel] [PATCH 2/2] configure: Use -fno-sanitize-recover

2025-01-16 Thread Vitaly Buka via ffmpeg-devel
UBSAN by default is just prints a mesage and moves on. This hides a few UBs in fate-suite. Signed-off-by: Vitaly Buka --- configure | 4 ++-- libavcodec/aacenc_pred.c | 1 + libavcodec/ffv1dec.c | 1 + libavcodec/ffv1enc_template.c | 1 + libavcodec/get_bits.h