Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpc8: fix hang with fuzzed file

2015-02-03 Thread Reimar Döffinger
On 03.02.2015, at 22:06, wm4 wrote: > On Tue, 3 Feb 2015 22:00:11 +0100 > Reimar Döffinger wrote: > >> On Tue, Feb 03, 2015 at 09:54:51PM +0100, wm4 wrote: >>> On Tue, 3 Feb 2015 21:47:57 +0100 >>> Reimar Döffinger wrote: >>> On Tue, Feb 03, 2015 at 07:04:12PM +0100, wm4 wrote: > This

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpc8: fix hang with fuzzed file

2015-02-03 Thread Michael Niedermayer
On Tue, Feb 03, 2015 at 10:06:28PM +0100, wm4 wrote: > On Tue, 3 Feb 2015 22:00:11 +0100 > Reimar Döffinger wrote: > > > On Tue, Feb 03, 2015 at 09:54:51PM +0100, wm4 wrote: > > > On Tue, 3 Feb 2015 21:47:57 +0100 > > > Reimar Döffinger wrote: > > > > > > > On Tue, Feb 03, 2015 at 07:04:12PM +0

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpc8: fix hang with fuzzed file

2015-02-03 Thread wm4
On Tue, 3 Feb 2015 22:00:11 +0100 Reimar Döffinger wrote: > On Tue, Feb 03, 2015 at 09:54:51PM +0100, wm4 wrote: > > On Tue, 3 Feb 2015 21:47:57 +0100 > > Reimar Döffinger wrote: > > > > > On Tue, Feb 03, 2015 at 07:04:12PM +0100, wm4 wrote: > > > > This can lead to an endless loop by seeking b

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpc8: fix hang with fuzzed file

2015-02-03 Thread Reimar Döffinger
On Tue, Feb 03, 2015 at 09:54:51PM +0100, wm4 wrote: > On Tue, 3 Feb 2015 21:47:57 +0100 > Reimar Döffinger wrote: > > > On Tue, Feb 03, 2015 at 07:04:12PM +0100, wm4 wrote: > > > This can lead to an endless loop by seeking back a few bytes after each > > > attempted chunk read. Assuming negative

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpc8: fix hang with fuzzed file

2015-02-03 Thread wm4
On Tue, 3 Feb 2015 21:47:57 +0100 Reimar Döffinger wrote: > On Tue, Feb 03, 2015 at 07:04:12PM +0100, wm4 wrote: > > This can lead to an endless loop by seeking back a few bytes after each > > attempted chunk read. Assuming negative sizes are always invalid, this > > is easy to fix. Other code in

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpc8: fix hang with fuzzed file

2015-02-03 Thread Reimar Döffinger
On Tue, Feb 03, 2015 at 07:04:12PM +0100, wm4 wrote: > This can lead to an endless loop by seeking back a few bytes after each > attempted chunk read. Assuming negative sizes are always invalid, this > is easy to fix. Other code in this demuxer treats negative sizes as > invalid as well. > > Fixes

[FFmpeg-devel] [PATCH 2/2] avformat/mpc8: fix hang with fuzzed file

2015-02-03 Thread wm4
This can lead to an endless loop by seeking back a few bytes after each attempted chunk read. Assuming negative sizes are always invalid, this is easy to fix. Other code in this demuxer treats negative sizes as invalid as well. Fixes ticket #4262. --- libavformat/mpc8.c | 4 1 file changed,