Re: [FFmpeg-devel] [PATCH 2/2] avformat/hnm: Only keep and parse what is needed later

2020-04-03 Thread Andreas Rheinhardt
Paul B Mahol: > ok if fate passed and it is covered. > > On 3/21/20, Andreas Rheinhardt wrote: >> The hnm demuxer's context struct contained lots of fields that are >> write-only variables or that are not used outside of parsing the header >> and that can therefore be replaced by local variables

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hnm: Only keep and parse what is needed later

2020-03-21 Thread Andreas Rheinhardt
Paul B Mahol: > ok if fate passed and it is covered. > It is not covered, yet I checked all the samples from [1] as well as the one from ticket #3464. (That the stuff I removed is actually unused can also be seen from the fact that I did not modify hnm_read_packet() at all.) - Andreas [1]: https

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hnm: Only keep and parse what is needed later

2020-03-21 Thread Paul B Mahol
ok if fate passed and it is covered. On 3/21/20, Andreas Rheinhardt wrote: > The hnm demuxer's context struct contained lots of fields that are > write-only variables or that are not used outside of parsing the header > and that can therefore be replaced by local variables of hnm_read_header(). >

[FFmpeg-devel] [PATCH 2/2] avformat/hnm: Only keep and parse what is needed later

2020-03-20 Thread Andreas Rheinhardt
The hnm demuxer's context struct contained lots of fields that are write-only variables or that are not used outside of parsing the header and that can therefore be replaced by local variables of hnm_read_header(). This commit removes all of these from the context; the second type has been replaced