Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Add subtitle support

2017-02-05 Thread Franklin Phillips
Sorry for the test failure, I didn't realise there were tests for HLS demuxer because the tests don't have HLS in their names. I am sending new patches which don't break the tests. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Add subtitle support

2016-12-31 Thread Michael Niedermayer
On Fri, Dec 30, 2016 at 08:10:05PM +, Franklin Phillips wrote: > Each subtile segment is a WebVTT file and needs to be demuxed > separately. These segments also contain a header to synchronize their > timing with the MPEG TS stream so those timestamps are requested from > the WebVTT demuxer thr

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Add subtitle support

2016-12-30 Thread Franklin Phillips
On Fri, Dec 16, 2016 at 05:13:50PM +0100, wm4 wrote: > On Thu, 15 Dec 2016 22:01:46 + > Franklin Phillips wrote: > > > Hi, > > > > I tested this code by converting HLS streams into mp4 files and it > > seemed to work fine. However I recently compiled mpv with these changes > > and when I pla

[FFmpeg-devel] [PATCH 2/2] avformat/hls: Add subtitle support

2016-12-30 Thread Franklin Phillips
Each subtile segment is a WebVTT file and needs to be demuxed separately. These segments also contain a header to synchronize their timing with the MPEG TS stream so those timestamps are requested from the WebVTT demuxer through an AVOption. Signed-off-by: Franklin Phillips --- libavformat/hls.c

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Add subtitle support

2016-12-16 Thread wm4
On Thu, 15 Dec 2016 22:01:46 + Franklin Phillips wrote: > Hi, > > I tested this code by converting HLS streams into mp4 files and it > seemed to work fine. However I recently compiled mpv with these changes > and when I play back the Apple example stream given in ticket #2833, it > seems to

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Add subtitle support

2016-12-15 Thread Franklin Phillips
Hi, I tested this code by converting HLS streams into mp4 files and it seemed to work fine. However I recently compiled mpv with these changes and when I play back the Apple example stream given in ticket #2833, it seems to skip a lot of subtitles. It works fine for the real world streams I'm usin

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Add subtitle support

2016-12-12 Thread Anssi Hannula
Hi, 07.12.2016, 00:04, Franklin Phillips kirjoitti: > Assuming the reason why my patch wasn't being merged was because it > didn't use the X-TIMESTAMP-MAP, I have included the changes for that. > > Those changes were basically a merge of work done by > anssi.hann...@iki.fi which is why I've cc'd

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Add subtitle support

2016-12-06 Thread Franklin Phillips
Assuming the reason why my patch wasn't being merged was because it didn't use the X-TIMESTAMP-MAP, I have included the changes for that. Those changes were basically a merge of work done by anssi.hann...@iki.fi which is why I've cc'd them. ___ ffmpeg-de

[FFmpeg-devel] [PATCH 2/2] avformat/hls: Add subtitle support

2016-12-06 Thread Franklin Phillips
Each subtile segment is a WebVTT file and needs to be demuxed separately. These segments also contain a header to synchronize their timing with the MPEG TS stream so those timestamps are requested from the WebVTT demuxer through an AVOption. Signed-off-by: Franklin Phillips --- libavformat/hls.c