Re: [FFmpeg-devel] [PATCH 2/2] avformat/dashdec: Don't needlessly strdup metadata

2021-03-02 Thread James Almer
On 3/2/2021 11:53 AM, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- Using separate lists for audio, video and subtitles leads to lots of code duplication in this demuxer; the only place where one gains a bit is in refresh_manifest (which is already buggy in itself because it le

[FFmpeg-devel] [PATCH 2/2] avformat/dashdec: Don't needlessly strdup metadata

2021-03-02 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- Using separate lists for audio, video and subtitles leads to lots of code duplication in this demuxer; the only place where one gains a bit is in refresh_manifest (which is already buggy in itself because it leaks upon error...). Is it really worth it? libav