Re: [FFmpeg-devel] [PATCH 2/2] avformat/aviobuf: prefer to use avio_read_partial()

2021-12-03 Thread lance . lmwang
On Fri, Dec 03, 2021 at 01:59:16PM +0200, Martin Storsjö wrote: > On Fri, 3 Dec 2021, lance.lmw...@gmail.com wrote: > > > On Fri, Dec 03, 2021 at 10:47:00AM +0100, Marton Balint wrote: > > > > > > > > > On Fri, 3 Dec 2021, lance.lmw...@gmail.com wrote: > > > > > > > From: Limin Wang > > > > >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/aviobuf: prefer to use avio_read_partial()

2021-12-03 Thread Martin Storsjö
On Fri, 3 Dec 2021, lance.lmw...@gmail.com wrote: On Fri, Dec 03, 2021 at 10:47:00AM +0100, Marton Balint wrote: On Fri, 3 Dec 2021, lance.lmw...@gmail.com wrote: From: Limin Wang This is allowed to read fewer bytes than requested. The missing bytes can be read in the next call. I don't

Re: [FFmpeg-devel] [PATCH 2/2] avformat/aviobuf: prefer to use avio_read_partial()

2021-12-03 Thread Marton Balint
On Fri, 3 Dec 2021, lance.lmw...@gmail.com wrote: On Fri, Dec 03, 2021 at 10:47:00AM +0100, Marton Balint wrote: On Fri, 3 Dec 2021, lance.lmw...@gmail.com wrote: From: Limin Wang This is allowed to read fewer bytes than requested. The missing bytes can be read in the next call. I do

Re: [FFmpeg-devel] [PATCH 2/2] avformat/aviobuf: prefer to use avio_read_partial()

2021-12-03 Thread lance . lmwang
On Fri, Dec 03, 2021 at 10:47:00AM +0100, Marton Balint wrote: > > > On Fri, 3 Dec 2021, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > This is allowed to read fewer bytes than requested. The missing bytes can > > be read in the next call. > > I don't think this is needed, after

Re: [FFmpeg-devel] [PATCH 2/2] avformat/aviobuf: prefer to use avio_read_partial()

2021-12-03 Thread Marton Balint
On Fri, 3 Dec 2021, lance.lmw...@gmail.com wrote: From: Limin Wang This is allowed to read fewer bytes than requested. The missing bytes can be read in the next call. I don't think this is needed, after all we want to read all data, there is no point in reading it in smaller chunks, no?

[FFmpeg-devel] [PATCH 2/2] avformat/aviobuf: prefer to use avio_read_partial()

2021-12-02 Thread lance . lmwang
From: Limin Wang This is allowed to read fewer bytes than requested. The missing bytes can be read in the next call. Signed-off-by: Limin Wang --- libavformat/aviobuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c index 14688