Re: [FFmpeg-devel] [PATCH 2/2] avcodec/svq3: Reject dx/dy beyond 16bit

2017-04-27 Thread Ronald S. Bultje
Hi, On Thu, Apr 27, 2017 at 10:26 AM, Nicolas George wrote: > L'octidi 8 floréal, an CCXXV, Ronald S. Bultje a écrit : > > Do we? Where is that documented? > > > > https://www.google.com/search?q=twos-complement+ffmpeg+site: > ffmpeg.org+-pipermail > > I think it is not documented anywhere but i

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/svq3: Reject dx/dy beyond 16bit

2017-04-27 Thread Nicolas George
L'octidi 8 floréal, an CCXXV, Ronald S. Bultje a écrit : > Do we? Where is that documented? > > https://www.google.com/search?q=twos-complement+ffmpeg+site:ffmpeg.org+-pipermail I think it is not documented anywhere but in the head of various developers, but I remember at least one other instance

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/svq3: Reject dx/dy beyond 16bit

2017-04-27 Thread Ronald S. Bultje
Hi, On Thu, Apr 27, 2017 at 9:56 AM, Michael Niedermayer wrote: > We require Twos-complement style definition for signed integers Do we? Where is that documented? https://www.google.com/search?q=twos-complement+ffmpeg+site:ffmpeg.org+-pipermail Ronald

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/svq3: Reject dx/dy beyond 16bit

2017-04-27 Thread Michael Niedermayer
On Thu, Apr 27, 2017 at 03:22:53PM +0200, Nicolas George wrote: > L'octidi 8 floréal, an CCXXV, Michael Niedermayer a écrit : > > The code does use 16bit sized arrays later so larger deltas would not work > > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/svq3.c | 2 +- > > 1 file

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/svq3: Reject dx/dy beyond 16bit

2017-04-27 Thread Nicolas George
L'octidi 8 floréal, an CCXXV, Michael Niedermayer a écrit : > The code does use 16bit sized arrays later so larger deltas would not work > > Signed-off-by: Michael Niedermayer > --- > libavcodec/svq3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/svq3.c b/

[FFmpeg-devel] [PATCH 2/2] avcodec/svq3: Reject dx/dy beyond 16bit

2017-04-27 Thread Michael Niedermayer
The code does use 16bit sized arrays later so larger deltas would not work Signed-off-by: Michael Niedermayer --- libavcodec/svq3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/svq3.c b/libavcodec/svq3.c index 3e35fd73d6..76a465b9c0 100644 --- a/libavcodec/svq3.