Re: [FFmpeg-devel] [PATCH 2/2] avcodec/sbrdsp_fixed: Fix integer overflow

2017-11-24 Thread Michael Niedermayer
On Thu, Nov 23, 2017 at 11:00:21PM +0100, Michael Niedermayer wrote: > On Wed, Nov 22, 2017 at 11:59:30PM +0100, Hendrik Leppkes wrote: > > On Wed, Nov 22, 2017 at 11:38 PM, Carl Eugen Hoyos > > wrote: > > > 2017-11-22 21:00 GMT+01:00 Michael Niedermayer : > > > > > >> diff --git a/libavcodec/sbr

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/sbrdsp_fixed: Fix integer overflow

2017-11-23 Thread James Almer
On 11/22/2017 7:59 PM, Hendrik Leppkes wrote: > On Wed, Nov 22, 2017 at 11:38 PM, Carl Eugen Hoyos wrote: >> 2017-11-22 21:00 GMT+01:00 Michael Niedermayer : >> >>> diff --git a/libavcodec/sbrdsp_fixed.c b/libavcodec/sbrdsp_fixed.c >>> index a0ef6859f1..0db932a105 100644 >>> --- a/libavcodec/sbrds

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/sbrdsp_fixed: Fix integer overflow

2017-11-23 Thread Michael Niedermayer
On Wed, Nov 22, 2017 at 11:59:30PM +0100, Hendrik Leppkes wrote: > On Wed, Nov 22, 2017 at 11:38 PM, Carl Eugen Hoyos wrote: > > 2017-11-22 21:00 GMT+01:00 Michael Niedermayer : > > > >> diff --git a/libavcodec/sbrdsp_fixed.c b/libavcodec/sbrdsp_fixed.c > >> index a0ef6859f1..0db932a105 100644 > >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/sbrdsp_fixed: Fix integer overflow

2017-11-22 Thread Hendrik Leppkes
On Wed, Nov 22, 2017 at 11:38 PM, Carl Eugen Hoyos wrote: > 2017-11-22 21:00 GMT+01:00 Michael Niedermayer : > >> diff --git a/libavcodec/sbrdsp_fixed.c b/libavcodec/sbrdsp_fixed.c >> index a0ef6859f1..0db932a105 100644 >> --- a/libavcodec/sbrdsp_fixed.c >> +++ b/libavcodec/sbrdsp_fixed.c >> @@ -1

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/sbrdsp_fixed: Fix integer overflow

2017-11-22 Thread Carl Eugen Hoyos
2017-11-22 21:00 GMT+01:00 Michael Niedermayer : > diff --git a/libavcodec/sbrdsp_fixed.c b/libavcodec/sbrdsp_fixed.c > index a0ef6859f1..0db932a105 100644 > --- a/libavcodec/sbrdsp_fixed.c > +++ b/libavcodec/sbrdsp_fixed.c > @@ -133,7 +133,7 @@ static av_always_inline SoftFloat autocorr_calc(int6

[FFmpeg-devel] [PATCH 2/2] avcodec/sbrdsp_fixed: Fix integer overflow

2017-11-22 Thread Michael Niedermayer
Fixes: signed integer overflow: 2147483598 + 64 cannot be represented in type 'int' Fixes: 4337/clusterfuzz-testcase-minimized-6192658616680448 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/