Re: [FFmpeg-devel] [PATCH 2/2] SCTE-35 support in hlsenc

2016-07-21 Thread Carl Eugen Hoyos
Carlos Fernandez Sanz ccextractor.org> writes: > -if (segment) { This change looks unrelated and should be part of a separate patch. Or is it related? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/lis

Re: [FFmpeg-devel] [PATCH 2/2] SCTE-35 support in hlsenc

2016-07-21 Thread James Almer
On 7/21/2016 7:31 PM, Carlos Fernandez Sanz wrote: > From: carlos > > Signed-off-by: carlos > --- > libavformat/Makefile | 1 + > libavformat/hlsenc.c | 179 +++--- > libavformat/scte_35.c | 489 > ++ > libavformat/scte_35.h | 76

Re: [FFmpeg-devel] [PATCH 2/2] SCTE-35 support in hlsenc

2016-07-21 Thread Steven Liu
2016-07-22 6:31 GMT+08:00 Carlos Fernandez Sanz : > From: carlos > > Signed-off-by: carlos > --- > libavformat/Makefile | 1 + > libavformat/hlsenc.c | 179 +++--- > libavformat/scte_35.c | 489 > ++ > libavformat/scte_35.h | 76 +

Re: [FFmpeg-devel] [PATCH 2/2] SCTE-35 support in hlsenc

2016-07-21 Thread Michael Niedermayer
On Thu, Jul 21, 2016 at 03:31:32PM -0700, Carlos Fernandez Sanz wrote: > From: carlos > > Signed-off-by: carlos > --- > libavformat/Makefile | 1 + > libavformat/hlsenc.c | 179 +++--- > libavformat/scte_35.c | 489 > ++ > libavfo

[FFmpeg-devel] [PATCH 2/2] SCTE-35 support in hlsenc

2016-07-21 Thread Carlos Fernandez Sanz
From: carlos Signed-off-by: carlos --- libavformat/Makefile | 1 + libavformat/hlsenc.c | 179 +++--- libavformat/scte_35.c | 489 ++ libavformat/scte_35.h | 76 4 files changed, 680 insertions(+), 65 deletions(-) create

Re: [FFmpeg-devel] [PATCH 2/2] SCTE-35 support in hlsenc

2016-07-21 Thread Michael Niedermayer
On Thu, Jul 21, 2016 at 03:31:32PM -0700, Carlos Fernandez Sanz wrote: > From: carlos > 2 quick comments, not a full review [...] > @@ -147,69 +156,55 @@ static int hls_delete_old_segments(HLSContext *hls) { > playlist_duration -= segment->duration; > previous_segment = segment