Re: [FFmpeg-devel] [PATCH 2/2] Add experimental support for Opus in ISO BMFF (MP4)

2017-04-11 Thread Michael Niedermayer
On Fri, Apr 07, 2017 at 04:29:36PM +1200, Matthew Gregan wrote: > At 2017-04-05T20:43:21-0300, James Almer wrote: > > > +/* OpusSpecificBox size plus magic for Ogg OpusHead header. */ > > > +size = atom.size + 16; > > > > This should be 8. "OpusHead" is not 16 bytes. > > > > > +avio_r

Re: [FFmpeg-devel] [PATCH 2/2] Add experimental support for Opus in ISO BMFF (MP4)

2017-04-06 Thread Matthew Gregan
At 2017-04-05T20:43:21-0300, James Almer wrote: > > +/* OpusSpecificBox size plus magic for Ogg OpusHead header. */ > > +size = atom.size + 16; > > This should be 8. "OpusHead" is not 16 bytes. > > > +avio_read(pb, st->codecpar->extradata + 9, size - 17); > > Same, this should be siz

Re: [FFmpeg-devel] [PATCH 2/2] Add experimental support for Opus in ISO BMFF (MP4)

2017-04-05 Thread James Almer
On 3/15/2017 10:19 PM, Matthew Gregan wrote: > Hi, > > The attached patch adds demuxing support for Opus audio codec in > ISOBMFF/MP4. This is based on v0.6.8 of the draft spec at > https://vfrmaniac.fushizen.eu/contents/opus_in_isobmff.html. > > Firefox supports demuxing/playback of these files

[FFmpeg-devel] [PATCH 2/2] Add experimental support for Opus in ISO BMFF (MP4)

2017-03-15 Thread Matthew Gregan
Hi, The attached patch adds demuxing support for Opus audio codec in ISOBMFF/MP4. This is based on v0.6.8 of the draft spec at https://vfrmaniac.fushizen.eu/contents/opus_in_isobmff.html. Firefox supports demuxing/playback of these files since Firefox 50. >From 9d6f1b4c12b08cf5fbba61bdeb31c785aa