Re: [FFmpeg-devel] [PATCH 18/40] avcodec/alacenc: Don't free unnecessarily

2020-09-14 Thread Andreas Rheinhardt
Paul B Mahol: > On Mon, Sep 14, 2020 at 07:27:25AM +0200, Andreas Rheinhardt wrote: >> The init function of the ALAC encoder calls its own close function >> if a call to ff_lpc_init() fails; yet nothing has been allocated before >> that point (except extradata which is freed generically) and ff_lpc

Re: [FFmpeg-devel] [PATCH 18/40] avcodec/alacenc: Don't free unnecessarily

2020-09-14 Thread Paul B Mahol
On Mon, Sep 14, 2020 at 07:27:25AM +0200, Andreas Rheinhardt wrote: > The init function of the ALAC encoder calls its own close function > if a call to ff_lpc_init() fails; yet nothing has been allocated before > that point (except extradata which is freed generically) and ff_lpc_init() > can be ex

[FFmpeg-devel] [PATCH 18/40] avcodec/alacenc: Don't free unnecessarily

2020-09-13 Thread Andreas Rheinhardt
The init function of the ALAC encoder calls its own close function if a call to ff_lpc_init() fails; yet nothing has been allocated before that point (except extradata which is freed generically) and ff_lpc_init() can be expected to clean up after itself on error (the documentation does not say any