Re: [FFmpeg-devel] [PATCH 18/18] lavf: document some AVStream fields as private

2020-10-09 Thread James Almer
On 10/9/2020 6:57 PM, James Almer wrote: > On 10/9/2020 6:55 PM, Michael Niedermayer wrote: >> On Fri, Oct 09, 2020 at 03:04:30PM +0200, Anton Khirnov wrote: >>> Specifically: pts_wrap_bits, first_dts, cur_dts. >>> They are supposed to be private and are located in the private section >>> of AVStre

Re: [FFmpeg-devel] [PATCH 18/18] lavf: document some AVStream fields as private

2020-10-09 Thread James Almer
On 10/9/2020 6:55 PM, Michael Niedermayer wrote: > On Fri, Oct 09, 2020 at 03:04:30PM +0200, Anton Khirnov wrote: >> Specifically: pts_wrap_bits, first_dts, cur_dts. >> They are supposed to be private and are located in the private section >> of AVStream, but ffmpeg.c currently accesses them regard

Re: [FFmpeg-devel] [PATCH 18/18] lavf: document some AVStream fields as private

2020-10-09 Thread Michael Niedermayer
On Fri, Oct 09, 2020 at 03:04:30PM +0200, Anton Khirnov wrote: > Specifically: pts_wrap_bits, first_dts, cur_dts. > They are supposed to be private and are located in the private section > of AVStream, but ffmpeg.c currently accesses them regardless. They > should be moved to AVStreamInternal once

[FFmpeg-devel] [PATCH 18/18] lavf: document some AVStream fields as private

2020-10-09 Thread Anton Khirnov
Specifically: pts_wrap_bits, first_dts, cur_dts. They are supposed to be private and are located in the private section of AVStream, but ffmpeg.c currently accesses them regardless. They should be moved to AVStreamInternal once that bug is fixed. Remove the marker for the private AVStream section,