Re: [FFmpeg-devel] [PATCH 15/38] lavu/opt: add array options

2024-03-03 Thread Marton Balint
On Sun, 3 Mar 2024, James Almer wrote: On 3/3/2024 12:53 PM, Diederick C. Niehorster wrote: On Sun, Mar 3, 2024 at 3:55 PM Anton Khirnov wrote: Quoting Marton Balint (2024-02-26 20:38:46) The more I think about it, it is actually a broader problem. You are changing the semantics of e

Re: [FFmpeg-devel] [PATCH 15/38] lavu/opt: add array options

2024-03-03 Thread James Almer
On 3/3/2024 12:53 PM, Diederick C. Niehorster wrote: On Sun, Mar 3, 2024 at 3:55 PM Anton Khirnov wrote: Quoting Marton Balint (2024-02-26 20:38:46) The more I think about it, it is actually a broader problem. You are changing the semantics of existing AV_OPT_TYPE_xxx types. So previously an

Re: [FFmpeg-devel] [PATCH 15/38] lavu/opt: add array options

2024-03-03 Thread Diederick C. Niehorster
On Sun, Mar 3, 2024 at 3:55 PM Anton Khirnov wrote: > Quoting Marton Balint (2024-02-26 20:38:46) > > The more I think about it, it is actually a broader problem. > > > > You are changing the semantics of existing AV_OPT_TYPE_xxx types. So > > previously an option with AV_OPT_TYPE_STRING used to

Re: [FFmpeg-devel] [PATCH 15/38] lavu/opt: add array options

2024-03-03 Thread Anton Khirnov
Quoting Marton Balint (2024-02-26 20:38:46) > The more I think about it, it is actually a broader problem. > > You are changing the semantics of existing AV_OPT_TYPE_xxx types. So > previously an option with AV_OPT_TYPE_STRING used to have default value in > default_val.str. After your patch, it

Re: [FFmpeg-devel] [PATCH 15/38] lavu/opt: add array options

2024-02-26 Thread Marton Balint
On Mon, 26 Feb 2024, Anton Khirnov wrote: Quoting Marton Balint (2024-02-23 20:05:06) On Fri, 23 Feb 2024, Anton Khirnov wrote: AVOption.array_max_size is added before AVOption.unit to avoid increasing sizeof(AVOption). --- doc/APIchanges| 3 + libavutil/opt.c | 344 ++

Re: [FFmpeg-devel] [PATCH 15/38] lavu/opt: add array options

2024-02-26 Thread James Almer
On 2/26/2024 2:14 PM, Anton Khirnov wrote: Quoting Marton Balint (2024-02-23 20:05:06) On Fri, 23 Feb 2024, Anton Khirnov wrote: AVOption.array_max_size is added before AVOption.unit to avoid increasing sizeof(AVOption). --- doc/APIchanges| 3 + libavutil/opt.c | 344 +

Re: [FFmpeg-devel] [PATCH 15/38] lavu/opt: add array options

2024-02-26 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Marton Balint (2024-02-23 20:05:06) >> >> >> On Fri, 23 Feb 2024, Anton Khirnov wrote: >> >>> AVOption.array_max_size is added before AVOption.unit to avoid >>> increasing sizeof(AVOption). >>> --- >>> doc/APIchanges| 3 + >>> libavutil/opt.c | 344 ++

Re: [FFmpeg-devel] [PATCH 15/38] lavu/opt: add array options

2024-02-26 Thread Anton Khirnov
Quoting Marton Balint (2024-02-23 20:05:06) > > > On Fri, 23 Feb 2024, Anton Khirnov wrote: > > > AVOption.array_max_size is added before AVOption.unit to avoid > > increasing sizeof(AVOption). > > --- > > doc/APIchanges| 3 + > > libavutil/opt.c | 344

Re: [FFmpeg-devel] [PATCH 15/38] lavu/opt: add array options

2024-02-23 Thread Marton Balint
On Fri, 23 Feb 2024, Anton Khirnov wrote: AVOption.array_max_size is added before AVOption.unit to avoid increasing sizeof(AVOption). --- doc/APIchanges| 3 + libavutil/opt.c | 344 -- libavutil/opt.h | 26 libavutil/tests/opt.c

[FFmpeg-devel] [PATCH 15/38] lavu/opt: add array options

2024-02-23 Thread Anton Khirnov
AVOption.array_max_size is added before AVOption.unit to avoid increasing sizeof(AVOption). --- doc/APIchanges| 3 + libavutil/opt.c | 344 -- libavutil/opt.h | 26 libavutil/tests/opt.c | 34 + tests/ref/fate/opt| 23 ++