Re: [FFmpeg-devel] [PATCH 10/39] lavc/ffv1dec: move the bitreader to stack

2024-07-20 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-07-18 20:18:15) > On Thu, Jul 18, 2024 at 05:31:16PM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-07-18 16:48:06) > > > On Thu, Jul 18, 2024 at 11:08:59AM +0200, Anton Khirnov wrote: > > > > Quoting Michael Niedermayer (2024-07-18 00:42:05) > [

Re: [FFmpeg-devel] [PATCH 10/39] lavc/ffv1dec: move the bitreader to stack

2024-07-18 Thread Michael Niedermayer
On Thu, Jul 18, 2024 at 05:31:16PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-07-18 16:48:06) > > On Thu, Jul 18, 2024 at 11:08:59AM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2024-07-18 00:42:05) [...] > > > > > > Another factor that matters in efficient ca

Re: [FFmpeg-devel] [PATCH 10/39] lavc/ffv1dec: move the bitreader to stack

2024-07-18 Thread Paul B Mahol
On Thu, Jul 18, 2024 at 5:31 PM Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-07-18 16:48:06) > > On Thu, Jul 18, 2024 at 11:08:59AM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2024-07-18 00:42:05) > > > > all the stuff should be put together close so its efficiently

Re: [FFmpeg-devel] [PATCH 10/39] lavc/ffv1dec: move the bitreader to stack

2024-07-18 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-07-18 16:48:06) > On Thu, Jul 18, 2024 at 11:08:59AM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-07-18 00:42:05) > > > all the stuff should be put together close so its efficiently > > > using CPU caches > > > > Which is why it shares its cac

Re: [FFmpeg-devel] [PATCH 10/39] lavc/ffv1dec: move the bitreader to stack

2024-07-18 Thread Michael Niedermayer
On Thu, Jul 18, 2024 at 11:08:59AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-07-18 00:42:05) > > all the stuff should be put together close so its efficiently > > using CPU caches > > Which is why it shares its cacheline with PutBitContext, because the > code benefits from ha

Re: [FFmpeg-devel] [PATCH 10/39] lavc/ffv1dec: move the bitreader to stack

2024-07-18 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-07-18 00:42:05) > all the stuff should be put together close so its efficiently > using CPU caches Which is why it shares its cacheline with PutBitContext, because the code benefits from having the both in the cache, right? And the 4-byte hole in PutBitContext is

Re: [FFmpeg-devel] [PATCH 10/39] lavc/ffv1dec: move the bitreader to stack

2024-07-17 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 07:11:25PM +0200, Anton Khirnov wrote: > There is no reason to place it in persistent state. > --- > libavcodec/ffv1.h | 1 - > libavcodec/ffv1dec.c | 28 +++- > libavcodec/ffv1dec_template.c | 23 --- > 3 fi

[FFmpeg-devel] [PATCH 10/39] lavc/ffv1dec: move the bitreader to stack

2024-07-16 Thread Anton Khirnov
There is no reason to place it in persistent state. --- libavcodec/ffv1.h | 1 - libavcodec/ffv1dec.c | 28 +++- libavcodec/ffv1dec_template.c | 23 --- 3 files changed, 27 insertions(+), 25 deletions(-) diff --git a/libavcodec/ffv