Re: [FFmpeg-devel] [PATCH 1/8] ffmdec: initialize f_cprv, f_stvi and f_stau

2015-03-09 Thread Andreas Cadhalpun
On 09.03.2015 13:20, Lukasz Marek wrote: BTW, did you produced this malformed file using ffmpeg tools or just prevent theoretical case? I fuzzed a file created by ffmpeg. Best regards, Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org ht

Re: [FFmpeg-devel] [PATCH 1/8] ffmdec: initialize f_cprv, f_stvi and f_stau

2015-03-09 Thread Lukasz Marek
On 9 March 2015 at 12:41, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 09.03.2015 10:53, Lukasz Marek wrote: > >> In fact this is a bit wrong. COMM is guaranteed unless malformed file is >> parsed. These variables are dedicated to detect doubled sections. This >> patch allows

Re: [FFmpeg-devel] [PATCH 1/8] ffmdec: initialize f_cprv, f_stvi and f_stau

2015-03-09 Thread Andreas Cadhalpun
On 09.03.2015 10:53, Lukasz Marek wrote: In fact this is a bit wrong. COMM is guaranteed unless malformed file is parsed. These variables are dedicated to detect doubled sections. This patch allows them to occur twice in that case. So they should be initialized to 0. This patch doesn't change a

Re: [FFmpeg-devel] [PATCH 1/8] ffmdec: initialize f_cprv, f_stvi and f_stau

2015-03-09 Thread Lukasz Marek
On 09.03.2015 02:45, Michael Niedermayer wrote: On Mon, Mar 09, 2015 at 12:02:55AM +0100, Andreas Cadhalpun wrote: Hi, attached patch fixes 'Conditional jump or move depends on uninitialized variables' valgrind warnings. Best regards, Andreas ffmdec.c |2 +- 1 file changed, 1 inserti

Re: [FFmpeg-devel] [PATCH 1/8] ffmdec: initialize f_cprv, f_stvi and f_stau

2015-03-08 Thread Michael Niedermayer
On Mon, Mar 09, 2015 at 12:02:55AM +0100, Andreas Cadhalpun wrote: > Hi, > > attached patch fixes 'Conditional jump or move depends on > uninitialized variables' valgrind warnings. > > Best regards, > Andreas > ffmdec.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > 4a297cdd7cdb82

[FFmpeg-devel] [PATCH 1/8] ffmdec: initialize f_cprv, f_stvi and f_stau

2015-03-08 Thread Andreas Cadhalpun
Hi, attached patch fixes 'Conditional jump or move depends on uninitialized variables' valgrind warnings. Best regards, Andreas >From 8b1088fa1509b1613d095fbe1c11eec6d251c95c Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun Date: Sun, 8 Mar 2015 22:52:47 +0100 Subject: [PATCH 1/8] ffmdec: ini