Re: [FFmpeg-devel] [PATCH 1/7] opt: Remove dead code

On Fri, Feb 06, 2015 at 04:07:36PM +, Timothy Gu wrote: > On Fri Feb 06 2015 at 1:28:09 AM Carl Eugen Hoyos wrote: > > > Timothy Gu gmail.com> writes: > > > > > if (!i || !*val) > > > return 0; > > > } > > > - > > > -return 0; > > > } > > > > > > > I fear tha

Re: [FFmpeg-devel] [PATCH 1/7] opt: Remove dead code

On Fri Feb 06 2015 at 1:28:09 AM Carl Eugen Hoyos wrote: > Timothy Gu gmail.com> writes: > > > if (!i || !*val) > > return 0; > > } > > - > > -return 0; > > } > > > I fear that some (broken) compilers will emit > a warning when this gets applied that we > request

Re: [FFmpeg-devel] [PATCH 1/7] opt: Remove dead code

Timothy Gu gmail.com> writes: > if (!i || !*val) > return 0; > } > - > -return 0; > } I fear that some (broken) compilers will emit a warning when this gets applied that we request to be interpreted as an error. Same for 3, 4 and 5. I don't remember if an assert

[FFmpeg-devel] [PATCH 1/7] opt: Remove dead code

--- libavutil/opt.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index c68dacc..45fcf95 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -256,8 +256,6 @@ static int set_string_number(void *obj, void *target_obj, const AVOp