Re: [FFmpeg-devel] [PATCH 1/7] avformat/utils: Add ff_stream_encode_params_copy()

2016-07-11 Thread Jan Sebechlebsky
On 07/11/2016 02:23 AM, Marton Balint wrote: +ret = av_dict_copy(&dst->metadata, src->metadata, 0); +if (ret < 0) +return ret; Since you are resetting every existing field in dst, it might make sense to free the metadata dictionary as well, before copying items to it. Th

Re: [FFmpeg-devel] [PATCH 1/7] avformat/utils: Add ff_stream_encode_params_copy()

2016-07-10 Thread Marton Balint
On Mon, 4 Jul 2016, sebechlebsky...@gmail.com wrote: From: Jan Sebechlebsky Signed-off-by: Jan Sebechlebsky --- libavformat/internal.h | 9 libavformat/utils.c| 56 ++ 2 files changed, 65 insertions(+) diff --git a/libavformat/inte

[FFmpeg-devel] [PATCH 1/7] avformat/utils: Add ff_stream_encode_params_copy()

2016-07-04 Thread sebechlebskyjan
From: Jan Sebechlebsky Signed-off-by: Jan Sebechlebsky --- libavformat/internal.h | 9 libavformat/utils.c| 56 ++ 2 files changed, 65 insertions(+) diff --git a/libavformat/internal.h b/libavformat/internal.h index 647ad65..1b44bea