Re: [FFmpeg-devel] [PATCH 1/7] avcodec: do not use AVFrame accessor

2017-04-23 Thread Muhammad Faiz
On Sat, Apr 22, 2017 at 4:27 PM, wm4 wrote: > On Sat, 22 Apr 2017 16:04:22 +0700 > Muhammad Faiz wrote: > >> Signed-off-by: Muhammad Faiz >> --- > > +1 to patches 1-7. As long as the accessors only trivially access > public fields, it's better (and less ugly) not to use accessors at all. add so

Re: [FFmpeg-devel] [PATCH 1/7] avcodec: do not use AVFrame accessor

2017-04-22 Thread Hendrik Leppkes
On Sat, Apr 22, 2017 at 8:57 PM, Nicolas George wrote: > Le tridi 3 floréal, an CCXXV, Aaron Levinson a écrit : >> Then why have the accessors at all if the fields are public? > > To ensure ABI compatibility with the fork, which has been dropped. > To elaborate on that, the accessors existed prim

Re: [FFmpeg-devel] [PATCH 1/7] avcodec: do not use AVFrame accessor

2017-04-22 Thread Nicolas George
Le tridi 3 floréal, an CCXXV, Aaron Levinson a écrit : > Then why have the accessors at all if the fields are public? To ensure ABI compatibility with the fork, which has been dropped. Regards, -- Nicolas George signature.asc Description: Digital signature __

Re: [FFmpeg-devel] [PATCH 1/7] avcodec: do not use AVFrame accessor

2017-04-22 Thread Aaron Levinson
On 4/22/2017 2:27 AM, wm4 wrote: On Sat, 22 Apr 2017 16:04:22 +0700 Muhammad Faiz wrote: Signed-off-by: Muhammad Faiz --- +1 to patches 1-7. As long as the accessors only trivially access public fields, it's better (and less ugly) not to use accessors at all. Then why have the accessors a

Re: [FFmpeg-devel] [PATCH 1/7] avcodec: do not use AVFrame accessor

2017-04-22 Thread wm4
On Sat, 22 Apr 2017 16:04:22 +0700 Muhammad Faiz wrote: > Signed-off-by: Muhammad Faiz > --- +1 to patches 1-7. As long as the accessors only trivially access public fields, it's better (and less ugly) not to use accessors at all. ___ ffmpeg-devel mai

[FFmpeg-devel] [PATCH 1/7] avcodec: do not use AVFrame accessor

2017-04-22 Thread Muhammad Faiz
Signed-off-by: Muhammad Faiz --- libavcodec/ac3dec.c | 2 +- libavcodec/cpia.c | 8 +++ libavcodec/cuvid.c | 6 ++--- libavcodec/decode.c | 62 - libavcodec/encode.c | 2 +- libavcodec/exr.c| 2 +- libavcodec/