Re: [FFmpeg-devel] [PATCH 1/5] dpxenc: fix padding in encode_gbrp12

2014-08-21 Thread Michael Niedermayer
On Thu, Aug 21, 2014 at 02:11:17PM +0200, Christophe Gisquet wrote: > Hi, > > 2014-08-20 11:35 GMT+02:00 James Darnley : > > (In an effort to help review...) > > > > This does move from per-pixel to per-line so if this is supposed to be > > correct then it looks good to me. > > Yes, this is a bug

Re: [FFmpeg-devel] [PATCH 1/5] dpxenc: fix padding in encode_gbrp12

2014-08-21 Thread Christophe Gisquet
Hi, 2014-08-20 11:35 GMT+02:00 James Darnley : > (In an effort to help review...) > > This does move from per-pixel to per-line so if this is supposed to be > correct then it looks good to me. Yes, this is a bugfix that is actually independent of the intent of the patchset. -- Christophe __

Re: [FFmpeg-devel] [PATCH 1/5] dpxenc: fix padding in encode_gbrp12

2014-08-20 Thread James Darnley
On 2014-08-20 10:10, Christophe Gisquet wrote: > It was added per pixel instead of per line. > --- > libavcodec/dpxenc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/dpxenc.c b/libavcodec/dpxenc.c > index 059d8c6..aca745b 100644 > --- a/libavcodec/dpxenc

[FFmpeg-devel] [PATCH 1/5] dpxenc: fix padding in encode_gbrp12

2014-08-20 Thread Christophe Gisquet
It was added per pixel instead of per line. --- libavcodec/dpxenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/dpxenc.c b/libavcodec/dpxenc.c index 059d8c6..aca745b 100644 --- a/libavcodec/dpxenc.c +++ b/libavcodec/dpxenc.c @@ -159,11 +159,11 @@ static void