Re: [FFmpeg-devel] [PATCH 1/5] avutil: add pixelutils API

2014-08-05 Thread Clément Bœsch
On Sun, Aug 03, 2014 at 12:36:19AM +0200, Michael Niedermayer wrote: > On Sat, Aug 02, 2014 at 11:34:07PM +0200, Clément Bœsch wrote: [...] > > +#ifdef TEST > > +#define W1 320 > > +#define H1 240 > > +#define W2 640 > > +#define H2 480 > > +int main(void) > > +{ > > +int i, a, ret = 0; > > +

Re: [FFmpeg-devel] [PATCH 1/5] avutil: add pixelutils API

2014-08-02 Thread Michael Niedermayer
On Sat, Aug 02, 2014 at 11:34:07PM +0200, Clément Bœsch wrote: > --- > configure | 2 + > doc/APIchanges | 3 + > libavutil/Makefile | 3 + > libavutil/pixelutils.c | 142 > libavutil/pixelutils

[FFmpeg-devel] [PATCH 1/5] avutil: add pixelutils API

2014-08-02 Thread Clément Bœsch
--- configure | 2 + doc/APIchanges | 3 + libavutil/Makefile | 3 + libavutil/pixelutils.c | 142 libavutil/pixelutils.h | 52 ++ libavutil/version.h | 2 +-

Re: [FFmpeg-devel] [PATCH 1/5] avutil: add pixelutils API

2014-08-02 Thread James Almer
On 02/08/14 6:13 PM, Clément Bœsch wrote: > On Sat, Aug 02, 2014 at 04:29:39PM -0300, James Almer wrote: >> On 02/08/14 3:20 PM, Clément Bœsch wrote: >>> +psrlq m0, m6, 32 >>> +paddw m6, m0 >>> +psrlq m0, m6, 16 >>> +paddw m6, m0 >>> +movdeax, m6

Re: [FFmpeg-devel] [PATCH 1/5] avutil: add pixelutils API

2014-08-02 Thread Clément Bœsch
On Sat, Aug 02, 2014 at 08:35:27PM +0200, Michael Niedermayer wrote: [...] > > +typedef struct AVPixelUtils { > > +/** > > + * Sum of absolute differences block functions. > > + * src1 and src2 addresses need to be aligned to the block size. > > + */ > > +av_pixelutils_sad_fn sa

Re: [FFmpeg-devel] [PATCH 1/5] avutil: add pixelutils API

2014-08-02 Thread Clément Bœsch
On Sat, Aug 02, 2014 at 04:29:39PM -0300, James Almer wrote: > On 02/08/14 3:20 PM, Clément Bœsch wrote: > > +psrlq m0, m6, 32 > > +paddw m6, m0 > > +psrlq m0, m6, 16 > > +paddw m6, m0 > > +movdeax, m6 > > +movzx eax, ax > > You could u

Re: [FFmpeg-devel] [PATCH 1/5] avutil: add pixelutils API

2014-08-02 Thread James Almer
On 02/08/14 3:20 PM, Clément Bœsch wrote: > +psrlq m0, m6, 32 > +paddw m6, m0 > +psrlq m0, m6, 16 > +paddw m6, m0 > +movdeax, m6 > +movzx eax, ax You could use the HADDW macro here. > +;-

Re: [FFmpeg-devel] [PATCH 1/5] avutil: add pixelutils API

2014-08-02 Thread Clément Bœsch
On Sat, Aug 02, 2014 at 08:30:39PM +0200, Lukasz Marek wrote: > >+static av_always_inline int sad_wxh(const uint8_t *src1, ptrdiff_t stride1, > >+const uint8_t *src2, ptrdiff_t stride2, > >+int w, int h) > >+{ > >+int x, y,

Re: [FFmpeg-devel] [PATCH 1/5] avutil: add pixelutils API

2014-08-02 Thread Michael Niedermayer
On Sat, Aug 02, 2014 at 08:20:17PM +0200, Clément Bœsch wrote: > --- > configure | 2 + > doc/APIchanges | 3 ++ > libavutil/Makefile | 2 + > libavutil/pixelutils.c | 85 ++ > libavutil/pixelutils.h

Re: [FFmpeg-devel] [PATCH 1/5] avutil: add pixelutils API

2014-08-02 Thread Lukasz Marek
+static av_always_inline int sad_wxh(const uint8_t *src1, ptrdiff_t stride1, +const uint8_t *src2, ptrdiff_t stride2, +int w, int h) +{ +int x, y, sum = 0; + +for (y = 0; y < h; y++) { +for (x = 0; x < w; x++)

[FFmpeg-devel] [PATCH 1/5] avutil: add pixelutils API

2014-08-02 Thread Clément Bœsch
--- configure | 2 + doc/APIchanges | 3 ++ libavutil/Makefile | 2 + libavutil/pixelutils.c | 85 ++ libavutil/pixelutils.h | 76 +++ libavutil/version.h |