Re: [FFmpeg-devel] [PATCH 1/5] avcodec/aac/aacdec_usac: Test ac in usac

2024-06-26 Thread Lynne via ffmpeg-devel
On 26/06/2024 21:45, Andreas Rheinhardt wrote: Lynne via ffmpeg-devel: On 26/06/2024 01:57, Michael Niedermayer wrote: On Wed, Jun 26, 2024 at 01:35:18AM +0200, Lynne via ffmpeg-devel wrote: On 24/06/2024 01:01, Michael Niedermayer wrote: ff_aac_usac_config_decode() needs AACDecContext to be

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/aac/aacdec_usac: Test ac in usac

2024-06-26 Thread Andreas Rheinhardt
Lynne via ffmpeg-devel: > On 26/06/2024 01:57, Michael Niedermayer wrote: >> On Wed, Jun 26, 2024 at 01:35:18AM +0200, Lynne via ffmpeg-devel wrote: >>> On 24/06/2024 01:01, Michael Niedermayer wrote: ff_aac_usac_config_decode() needs AACDecContext to be set but some callers pass NUL

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/aac/aacdec_usac: Test ac in usac

2024-06-26 Thread Michael Niedermayer
On Wed, Jun 26, 2024 at 08:58:27AM +0200, Lynne via ffmpeg-devel wrote: > On 26/06/2024 01:57, Michael Niedermayer wrote: > > On Wed, Jun 26, 2024 at 01:35:18AM +0200, Lynne via ffmpeg-devel wrote: > > > On 24/06/2024 01:01, Michael Niedermayer wrote: > > > > ff_aac_usac_config_decode() needs AACDe

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/aac/aacdec_usac: Test ac in usac

2024-06-25 Thread Lynne via ffmpeg-devel
On 26/06/2024 01:57, Michael Niedermayer wrote: On Wed, Jun 26, 2024 at 01:35:18AM +0200, Lynne via ffmpeg-devel wrote: On 24/06/2024 01:01, Michael Niedermayer wrote: ff_aac_usac_config_decode() needs AACDecContext to be set but some callers pass NULL. I have no real testcase to implement/tes

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/aac/aacdec_usac: Test ac in usac

2024-06-25 Thread Michael Niedermayer
On Wed, Jun 26, 2024 at 01:35:18AM +0200, Lynne via ffmpeg-devel wrote: > On 24/06/2024 01:01, Michael Niedermayer wrote: > > ff_aac_usac_config_decode() needs AACDecContext to be set but some callers > > pass NULL. > > > > I have no real testcase to implement/test this, so failing in this case >

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/aac/aacdec_usac: Test ac in usac

2024-06-25 Thread Lynne via ffmpeg-devel
On 24/06/2024 01:01, Michael Niedermayer wrote: ff_aac_usac_config_decode() needs AACDecContext to be set but some callers pass NULL. I have no real testcase to implement/test this, so failing in this case seems safest. Fixes: member access within null pointer of type 'AACDecContext' (aka 'stru

[FFmpeg-devel] [PATCH 1/5] avcodec/aac/aacdec_usac: Test ac in usac

2024-06-23 Thread Michael Niedermayer
ff_aac_usac_config_decode() needs AACDecContext to be set but some callers pass NULL. I have no real testcase to implement/test this, so failing in this case seems safest. Fixes: member access within null pointer of type 'AACDecContext' (aka 'struct AACDecContext') Fixes: 69435/clusterfuzz-test