Re: [FFmpeg-devel] [PATCH 1/4] Remove unnecessary mem.h inclusions

2021-02-09 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2021-02-04 12:06:15) >> Anton Khirnov: >>> Quoting Andreas Rheinhardt (2021-02-04 01:05:05) Thanks for the report. I have only checked for whether the relevant translation unit uses any of the alloc/free functions (because DECLARE_ALIGNED

Re: [FFmpeg-devel] [PATCH 1/4] Remove unnecessary mem.h inclusions

2021-02-04 Thread Anton Khirnov
Quoting Nicolas George (2021-02-04 15:48:03) > Anton Khirnov (12021-02-04): > > I don't think we have an official project policy on this, but I would > > be in favor of something like: > > > > All installed headers are only guaranteed to provide those > > identifiers that are explicitly de

Re: [FFmpeg-devel] [PATCH 1/4] Remove unnecessary mem.h inclusions

2021-02-04 Thread Nicolas George
Anton Khirnov (12021-02-04): > I don't think we have an official project policy on this, but I would > be in favor of something like: > > All installed headers are only guaranteed to provide those > identifiers that are explicitly declared in them. Users must not > rely on an installed

Re: [FFmpeg-devel] [PATCH 1/4] Remove unnecessary mem.h inclusions

2021-02-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2021-02-04 12:06:15) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2021-02-04 01:05:05) > >> Thanks for the report. I have only checked for whether the relevant > >> translation unit uses any of the alloc/free functions (because > >> DECLARE_ALIGNED is already provide

Re: [FFmpeg-devel] [PATCH 1/4] Remove unnecessary mem.h inclusions

2021-02-04 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2021-02-04 01:05:05) >> Thanks for the report. I have only checked for whether the relevant >> translation unit uses any of the alloc/free functions (because >> DECLARE_ALIGNED is already provided by mem_internal.h), but I have not >> taken into account

Re: [FFmpeg-devel] [PATCH 1/4] Remove unnecessary mem.h inclusions

2021-02-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2021-02-04 01:05:05) > Thanks for the report. I have only checked for whether the relevant > translation unit uses any of the alloc/free functions (because > DECLARE_ALIGNED is already provided by mem_internal.h), but I have not > taken into account stuff that is include

Re: [FFmpeg-devel] [PATCH 1/4] Remove unnecessary mem.h inclusions

2021-02-03 Thread Andreas Rheinhardt
Michael Niedermayer: > On Wed, Feb 03, 2021 at 11:27:46AM +0100, Andreas Rheinhardt wrote: >> Signed-off-by: Andreas Rheinhardt >> --- >> fftools/ffmpeg_qsv.c| 1 - >> libavcodec/aactab.c | 1 - >> libavcodec/arbc.c | 1 - >

Re: [FFmpeg-devel] [PATCH 1/4] Remove unnecessary mem.h inclusions

2021-02-03 Thread Michael Niedermayer
On Wed, Feb 03, 2021 at 11:27:46AM +0100, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > fftools/ffmpeg_qsv.c| 1 - > libavcodec/aactab.c | 1 - > libavcodec/arbc.c | 1 - > libavcodec/argo.c

[FFmpeg-devel] [PATCH 1/4] Remove unnecessary mem.h inclusions

2021-02-03 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg_qsv.c| 1 - libavcodec/aactab.c | 1 - libavcodec/arbc.c | 1 - libavcodec/argo.c | 1 - libavcodec/dcadsp.c | 1 - liba