Re: [FFmpeg-devel] [PATCH 1/3 v2] avutil: Add GOP timecode frame side data

2016-02-01 Thread Michael Niedermayer
On Mon, Feb 01, 2016 at 01:39:41PM +, Derek Buitenhuis wrote: > On 1/31/2016 8:29 PM, Michael Niedermayer wrote: > > the spec says this: > > "The time code refers to the first picture after the group of > > pictures header that has a temporal_reference of zero." > > I *think* this is the

Re: [FFmpeg-devel] [PATCH 1/3 v2] avutil: Add GOP timecode frame side data

2016-02-01 Thread Derek Buitenhuis
On 1/31/2016 8:29 PM, Michael Niedermayer wrote: > the spec says this: > "The time code refers to the first picture after the group of > pictures header that has a temporal_reference of zero." I *think* this is the frame I attach the side data too, but I'm not a master of the mpeg*.c files.

Re: [FFmpeg-devel] [PATCH 1/3 v2] avutil: Add GOP timecode frame side data

2016-01-31 Thread Michael Niedermayer
On Sun, Jan 31, 2016 at 08:17:04PM +, Derek Buitenhuis wrote: > On 1/31/2016 8:02 PM, Michael Niedermayer wrote: > > whats the first frame of a gop ? > > for example there may be B frames prior to an I frame in display > > order > > In this case, it's the first frame output after decoding the

Re: [FFmpeg-devel] [PATCH 1/3 v2] avutil: Add GOP timecode frame side data

2016-01-31 Thread Derek Buitenhuis
On 1/31/2016 8:02 PM, Michael Niedermayer wrote: > whats the first frame of a gop ? > for example there may be B frames prior to an I frame in display > order In this case, it's the first frame output after decoding the GOP header. Do you think there is a better way to word it? - Derek _

Re: [FFmpeg-devel] [PATCH 1/3 v2] avutil: Add GOP timecode frame side data

2016-01-31 Thread Michael Niedermayer
On Sun, Jan 31, 2016 at 02:36:18PM +, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > doc/APIchanges | 3 +++ > libavutil/frame.c | 1 + > libavutil/frame.h | 7 ++- > libavutil/version.h | 4 ++-- > 4 files changed, 12 insertions(+), 3 deletions(-) > > diff --

[FFmpeg-devel] [PATCH 1/3 v2] avutil: Add GOP timecode frame side data

2016-01-31 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- doc/APIchanges | 3 +++ libavutil/frame.c | 1 + libavutil/frame.h | 7 ++- libavutil/version.h | 4 ++-- 4 files changed, 12 insertions(+), 3 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 15aefb5..45ccf13 100644 --- a/doc/APIcha