Re: [FFmpeg-devel] [PATCH 1/3] vaapi_encode_h264: Fix setting colour properties

2020-11-03 Thread Mark Thompson
On 03/11/2020 16:51, Eoff, Ullysses A wrote:>> -Original Message- From: ffmpeg-devel On Behalf Of Jan Ekström Sent: Tuesday, November 03, 2020 3:17 AM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 1/3] vaapi_encode_h264: Fix setting

Re: [FFmpeg-devel] [PATCH 1/3] vaapi_encode_h264: Fix setting colour properties

2020-11-03 Thread Eoff, Ullysses A
> -Original Message- > From: ffmpeg-devel On Behalf Of Jan Ekström > Sent: Tuesday, November 03, 2020 3:17 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 1/3] vaapi_encode_h264: Fix setting colour > properties > > On T

Re: [FFmpeg-devel] [PATCH 1/3] vaapi_encode_h264: Fix setting colour properties

2020-11-03 Thread Jan Ekström
On Tue, Nov 3, 2020 at 12:59 AM Mark Thompson wrote: > > The properties should always be set; only the presence flags want to be > conditional. > > Fixes #8959. > --- Thanks for this on such short notice. Patch set LGTM, and simplifies the logic nicely for these values (always set, only set flags

[FFmpeg-devel] [PATCH 1/3] vaapi_encode_h264: Fix setting colour properties

2020-11-02 Thread Mark Thompson
The properties should always be set; only the presence flags want to be conditional. Fixes #8959. --- libavcodec/vaapi_encode_h264.c | 34 -- 1 file changed, 12 insertions(+), 22 deletions(-) diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h2