Re: [FFmpeg-devel] [PATCH 1/3] lavu/error: add AVERROR_REDO.

2015-11-27 Thread Marton Balint
On Fri, 27 Nov 2015, Nicolas George wrote: I am not sure distinguishing the different cases (packet in a disabled stream, utility data, corrupted data until a sync word) is very important. I think it is, loss off sync means data loss, which is a severe error condition for some use cases. Any

Re: [FFmpeg-devel] [PATCH 1/3] lavu/error: add AVERROR_REDO.

2015-11-27 Thread Ronald S. Bultje
Hi, On Thu, Nov 26, 2015 at 6:19 PM, Nicolas George wrote: > Le sextidi 6 frimaire, an CCXXIV, Marton Balint a écrit : > > Maybe I am missing something, but the existing error AVERROR(EINTR) > cannot > > be used for this? > > It would be less broken than EAGAIN, since it is almost always treated

Re: [FFmpeg-devel] [PATCH 1/3] lavu/error: add AVERROR_REDO.

2015-11-27 Thread Derek Buitenhuis
On 11/27/2015 7:07 AM, Nicolas George wrote: > So basically, the question boils down to what people consider the better > design: adding a loop in every demuxer that needs it, or have the loop in > the framework. I'm erring on the latter approach, for one reason: This changes beavior, but does not

Re: [FFmpeg-devel] [PATCH 1/3] lavu/error: add AVERROR_REDO.

2015-11-26 Thread Nicolas George
Le septidi 7 frimaire, an CCXXIV, Marton Balint a écrit : > I agree that a loop is necessary if a demuxer can return an error with such > semantics to maintain compatibility. So basically, the question boils down to what people consider the better design: adding a loop in every demuxer that needs

Re: [FFmpeg-devel] [PATCH 1/3] lavu/error: add AVERROR_REDO.

2015-11-26 Thread Marton Balint
On Fri, 27 Nov 2015, Nicolas George wrote: Le sextidi 6 frimaire, an CCXXIV, Marton Balint a écrit : Maybe I am missing something, but the existing error AVERROR(EINTR) cannot be used for this? It would be less broken than EAGAIN, since it is almost always treated like that by Unix code. Bu

Re: [FFmpeg-devel] [PATCH 1/3] lavu/error: add AVERROR_REDO.

2015-11-26 Thread Nicolas George
Le sextidi 6 frimaire, an CCXXIV, Marton Balint a écrit : > Maybe I am missing something, but the existing error AVERROR(EINTR) cannot > be used for this? It would be less broken than EAGAIN, since it is almost always treated like that by Unix code. But without the loop in utils.c (patch 2/3 in t

Re: [FFmpeg-devel] [PATCH 1/3] lavu/error: add AVERROR_REDO.

2015-11-26 Thread Marton Balint
On Thu, 26 Nov 2015, Nicolas George wrote: It is meant for demuxers to signal that they consumed data but did not return a packet; the framework is then supposed to loop. Maybe I am missing something, but the existing error AVERROR(EINTR) cannot be used for this? Thanks, Marton ___

Re: [FFmpeg-devel] [PATCH 1/3] lavu/error: add AVERROR_REDO.

2015-11-26 Thread Michael Niedermayer
On Thu, Nov 26, 2015 at 07:47:52PM +0100, Nicolas George wrote: > It is meant for demuxers to signal that they consumed data > but did not return a packet; the framework is then supposed > to loop. > > Signed-off-by: Nicolas George > --- > libavutil/error.c | 1 + > libavutil/error.h | 2 +-

[FFmpeg-devel] [PATCH 1/3] lavu/error: add AVERROR_REDO.

2015-11-26 Thread Nicolas George
It is meant for demuxers to signal that they consumed data but did not return a packet; the framework is then supposed to loop. Signed-off-by: Nicolas George --- libavutil/error.c | 1 + libavutil/error.h | 2 +- libavutil/version.h | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-)