Re: [FFmpeg-devel] [PATCH 1/3] lavf: identify MP2 as a distinct container from MP3

2016-12-22 Thread Tobias Rapp
On 21.12.2016 20:50, compn wrote: On Wed, 21 Dec 2016 12:51:18 -0600 Rodger Combs wrote: On Dec 21, 2016, at 02:27, Carl Eugen Hoyos wrote: 2016-12-21 5:48 GMT+01:00 Rodger Combs : This allows us to report the correct codec ID here Just curious: What does this fix? Reporting in ffprob

Re: [FFmpeg-devel] [PATCH 1/3] lavf: identify MP2 as a distinct container from MP3

2016-12-21 Thread Nicolas George
Le primidi 1er nivôse, an CCXXV, compn a écrit : > if mp2 is a problem, i would rather make it more difficult for the user > to encode mp2. by defaulting to mp3 and / or printing a warning message > about mp2. honestly i cant remember any good coming from someone using > mp2. > > mp2 is dead, long

Re: [FFmpeg-devel] [PATCH 1/3] lavf: identify MP2 as a distinct container from MP3

2016-12-21 Thread Rodger Combs
> On Dec 21, 2016, at 13:50, compn wrote: > > On Wed, 21 Dec 2016 12:51:18 -0600 > Rodger Combs wrote: > >> >>> On Dec 21, 2016, at 02:27, Carl Eugen Hoyos >>> wrote: >>> >>> 2016-12-21 5:48 GMT+01:00 Rodger Combs : This allows us to report the correct codec ID here >>> >>> Just curio

Re: [FFmpeg-devel] [PATCH 1/3] lavf: identify MP2 as a distinct container from MP3

2016-12-21 Thread James Almer
On 12/21/2016 4:50 PM, compn wrote: > On Wed, 21 Dec 2016 12:51:18 -0600 > Rodger Combs wrote: > >> >>> On Dec 21, 2016, at 02:27, Carl Eugen Hoyos >>> wrote: >>> >>> 2016-12-21 5:48 GMT+01:00 Rodger Combs : This allows us to report the correct codec ID here >>> >>> Just curious: What does

Re: [FFmpeg-devel] [PATCH 1/3] lavf: identify MP2 as a distinct container from MP3

2016-12-21 Thread compn
On Wed, 21 Dec 2016 12:51:18 -0600 Rodger Combs wrote: > > > On Dec 21, 2016, at 02:27, Carl Eugen Hoyos > > wrote: > > > > 2016-12-21 5:48 GMT+01:00 Rodger Combs : > >> This allows us to report the correct codec ID here > > > > Just curious: What does this fix? > > Reporting in ffprobe, or

Re: [FFmpeg-devel] [PATCH 1/3] lavf: identify MP2 as a distinct container from MP3

2016-12-21 Thread Rodger Combs
> On Dec 21, 2016, at 02:27, Carl Eugen Hoyos wrote: > > 2016-12-21 5:48 GMT+01:00 Rodger Combs : >> This allows us to report the correct codec ID here > > Just curious: What does this fix? Reporting in ffprobe, or when using lavf as a library. Some devices and decoders either refuse to decod

Re: [FFmpeg-devel] [PATCH 1/3] lavf: identify MP2 as a distinct container from MP3

2016-12-21 Thread Michael Niedermayer
On Tue, Dec 20, 2016 at 10:48:12PM -0600, Rodger Combs wrote: > This allows us to report the correct codec ID here > --- > libavformat/allformats.c | 2 +- > libavformat/mp3dec.c | 62 > +++- > libavformat/version.h| 2 +- > 3 files changed, 4

Re: [FFmpeg-devel] [PATCH 1/3] lavf: identify MP2 as a distinct container from MP3

2016-12-21 Thread Carl Eugen Hoyos
2016-12-21 5:48 GMT+01:00 Rodger Combs : > This allows us to report the correct codec ID here Just curious: What does this fix? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 1/3] lavf: identify MP2 as a distinct container from MP3

2016-12-20 Thread Rodger Combs
This allows us to report the correct codec ID here --- libavformat/allformats.c | 2 +- libavformat/mp3dec.c | 62 +++- libavformat/version.h| 2 +- 3 files changed, 42 insertions(+), 24 deletions(-) diff --git a/libavformat/allformats.c b/lib