Re: [FFmpeg-devel] [PATCH 1/3] ffmpeg: set tty mode and signals after parsing options.

2016-03-20 Thread Michael Niedermayer
On Wed, Mar 16, 2016 at 11:01:02PM +0100, Nicolas George wrote: > Le septidi 27 ventôse, an CCXXIV, Michael Niedermayer a écrit : > > iam not saying its necessary (or that its not), just that its done > > currently and would not be done anymore in the future. > > But what? What is done now and not

Re: [FFmpeg-devel] [PATCH 1/3] ffmpeg: set tty mode and signals after parsing options.

2016-03-19 Thread Nicolas George
Le septidi 27 ventôse, an CCXXIV, Michael Niedermayer a écrit : > This will prevent cleanup from being done on ctrl-c during the input > open stage > especially if input open is stuck due to network or whatever the > user likely would abort it. I had not noticed that ffmpeg_parse_options() also op

Re: [FFmpeg-devel] [PATCH 1/3] ffmpeg: set tty mode and signals after parsing options.

2016-03-19 Thread Michael Niedermayer
On Sun, Mar 13, 2016 at 12:07:46PM +0100, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > ffmpeg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > > It seems more logical, and the next patch does not work without. > > > diff --git a/ffmpeg.c b/ffmpeg.c > index 9a

Re: [FFmpeg-devel] [PATCH 1/3] ffmpeg: set tty mode and signals after parsing options.

2016-03-19 Thread Michael Niedermayer
On Wed, Mar 16, 2016 at 07:10:38PM +0100, Nicolas George wrote: > Le septidi 27 ventôse, an CCXXIV, Michael Niedermayer a écrit : > > This will prevent cleanup from being done on ctrl-c during the input > > open stage > > especially if input open is stuck due to network or whatever the > > user lik

Re: [FFmpeg-devel] [PATCH 1/3] ffmpeg: set tty mode and signals after parsing options.

2016-03-19 Thread Nicolas George
Le septidi 27 ventôse, an CCXXIV, Michael Niedermayer a écrit : > iam not saying its necessary (or that its not), just that its done > currently and would not be done anymore in the future. But what? What is done now and not with this patch. I do now know what cleanup you are referring to. Regard

[FFmpeg-devel] [PATCH 1/3] ffmpeg: set tty mode and signals after parsing options.

2016-03-13 Thread Nicolas George
Signed-off-by: Nicolas George --- ffmpeg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) It seems more logical, and the next patch does not work without. diff --git a/ffmpeg.c b/ffmpeg.c index 9a14294..1887946 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -4306,8 +4306,6 @@ int main(int