Re: [FFmpeg-devel] [PATCH 1/3] avutil/opt: Fix setting int64 to its maximum

2016-11-20 Thread Michael Niedermayer
On Sun, Nov 20, 2016 at 08:53:19PM +0100, Andreas Cadhalpun wrote: > On 20.11.2016 12:57, Michael Niedermayer wrote: > > Found-by: Andreas > > Signed-off-by: Michael Niedermayer > > --- > > libavutil/opt.c | 8 +--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/lib

Re: [FFmpeg-devel] [PATCH 1/3] avutil/opt: Fix setting int64 to its maximum

2016-11-20 Thread Andreas Cadhalpun
On 20.11.2016 12:57, Michael Niedermayer wrote: > Found-by: Andreas > Signed-off-by: Michael Niedermayer > --- > libavutil/opt.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/libavutil/opt.c b/libavutil/opt.c > index cd16bd1..6669356 100644 > --- a/libavutil/op

Re: [FFmpeg-devel] [PATCH 1/3] avutil/opt: Fix setting int64 to its maximum

2016-11-20 Thread Carl Eugen Hoyos
2016-11-20 12:57 GMT+01:00 Michael Niedermayer : > -case AV_OPT_TYPE_INT64: > -*(int64_t *)dst = llrint(num / den) * intnum; > -break; > +case AV_OPT_TYPE_INT64:{ > +double d = num / den; > +if (intnum == 1 && d == (double)INT64_MAX) *(int64_t *)dst = > INT

[FFmpeg-devel] [PATCH 1/3] avutil/opt: Fix setting int64 to its maximum

2016-11-20 Thread Michael Niedermayer
Found-by: Andreas Signed-off-by: Michael Niedermayer --- libavutil/opt.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index cd16bd1..6669356 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -126,9 +126,11 @@ static int write_nu