Re: [FFmpeg-devel] [PATCH 1/3] avformat/libquvi: fix error handling

2015-05-31 Thread Michael Niedermayer
On Wed, Apr 08, 2015 at 07:16:36PM +0200, Gilles Chanteperdrix wrote: > avoid calling cleanup functions on uninitialized variables > > Signed-off-by: Gilles Chanteperdrix > --- > libavformat/libquvi.c | 41 + > 1 file changed, 25 insertions(+), 16 deletion

Re: [FFmpeg-devel] [PATCH 1/3] avformat/libquvi: fix error handling

2015-04-08 Thread Michael Niedermayer
On Wed, Apr 08, 2015 at 09:46:30PM +0200, Gilles Chanteperdrix wrote: > On Wed, Apr 08, 2015 at 09:13:11PM +0200, Michael Niedermayer wrote: > > On Wed, Apr 08, 2015 at 07:16:36PM +0200, Gilles Chanteperdrix wrote: > > > avoid calling cleanup functions on uninitialized variables > > > > > > Signed

Re: [FFmpeg-devel] [PATCH 1/3] avformat/libquvi: fix error handling

2015-04-08 Thread Gilles Chanteperdrix
On Wed, Apr 08, 2015 at 09:13:11PM +0200, Michael Niedermayer wrote: > On Wed, Apr 08, 2015 at 07:16:36PM +0200, Gilles Chanteperdrix wrote: > > avoid calling cleanup functions on uninitialized variables > > > > Signed-off-by: Gilles Chanteperdrix > > --- > > libavformat/libquvi.c | 41 +

Re: [FFmpeg-devel] [PATCH 1/3] avformat/libquvi: fix error handling

2015-04-08 Thread Michael Niedermayer
On Wed, Apr 08, 2015 at 09:22:06PM +0200, Nicolas George wrote: > Le nonidi 19 germinal, an CCXXIII, Michael Niedermayer a écrit : > > > + av_log(s, AV_LOG_ERROR, "%s\n", quvi_strerror(q, rc)); > > is quvi_strerror() thread safe ? > > Looking at the code, it is thread-safe as long as the q argumen

Re: [FFmpeg-devel] [PATCH 1/3] avformat/libquvi: fix error handling

2015-04-08 Thread Nicolas George
Le nonidi 19 germinal, an CCXXIII, Michael Niedermayer a écrit : > > + av_log(s, AV_LOG_ERROR, "%s\n", quvi_strerror(q, rc)); > is quvi_strerror() thread safe ? Looking at the code, it is thread-safe as long as the q argument is not used concurrently. Regards, -- Nicolas George signature.

Re: [FFmpeg-devel] [PATCH 1/3] avformat/libquvi: fix error handling

2015-04-08 Thread Michael Niedermayer
On Wed, Apr 08, 2015 at 07:16:36PM +0200, Gilles Chanteperdrix wrote: > avoid calling cleanup functions on uninitialized variables > > Signed-off-by: Gilles Chanteperdrix > --- > libavformat/libquvi.c | 41 + > 1 file changed, 25 insertions(+), 16 deletion

[FFmpeg-devel] [PATCH 1/3] avformat/libquvi: fix error handling

2015-04-08 Thread Gilles Chanteperdrix
avoid calling cleanup functions on uninitialized variables Signed-off-by: Gilles Chanteperdrix --- libavformat/libquvi.c | 41 + 1 file changed, 25 insertions(+), 16 deletions(-) diff --git a/libavformat/libquvi.c b/libavformat/libquvi.c index 7c5f7a2..e8