Re: [FFmpeg-devel] [PATCH 1/3] avformat/file: check for lseek() failure

2024-05-25 Thread Rémi Denis-Courmont
Le lauantaina 25. toukokuuta 2024, 15.19.51 EEST Michael Niedermayer a écrit : > On Sat, May 25, 2024 at 02:38:07PM +0300, Rémi Denis-Courmont wrote: > > Le lauantaina 25. toukokuuta 2024, 14.18.12 EEST Michael Niedermayer a écrit : > > > Fixes: CID1559855 Unchecked return value from library > >

Re: [FFmpeg-devel] [PATCH 1/3] avformat/file: check for lseek() failure

2024-05-25 Thread Michael Niedermayer
On Sat, May 25, 2024 at 02:38:07PM +0300, Rémi Denis-Courmont wrote: > Le lauantaina 25. toukokuuta 2024, 14.18.12 EEST Michael Niedermayer a écrit : > > Fixes: CID1559855 Unchecked return value from library > > This is again very misleading. Logging an error (that most people won't even > see) i

Re: [FFmpeg-devel] [PATCH 1/3] avformat/file: check for lseek() failure

2024-05-25 Thread Rémi Denis-Courmont
Le lauantaina 25. toukokuuta 2024, 14.18.12 EEST Michael Niedermayer a écrit : > Fixes: CID1559855 Unchecked return value from library This is again very misleading. Logging an error (that most people won't even see) is not fixing a bug. Either this is not a bug, and this patch can't be fixing a

[FFmpeg-devel] [PATCH 1/3] avformat/file: check for lseek() failure

2024-05-25 Thread Michael Niedermayer
Fixes: CID1559855 Unchecked return value from library Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/file.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/file.c b/libavformat/file.c index 0ed4cff266c..e2ef85aa705 10064