Re: [FFmpeg-devel] [PATCH 1/3] avdevice/xv: change codec to wrapped avframe

2020-04-06 Thread Carl Eugen Hoyos
Am Mo., 6. Apr. 2020 um 23:13 Uhr schrieb Nicolas George : > > Carl Eugen Hoyos (12020-04-06): > > Thank you, I had never realized this in all the years I (thought I) had > > to specify --enable-decoder=rawvideo,wrapped_avframe... > > I am not sure exactly what you are saying. I tried to explain t

Re: [FFmpeg-devel] [PATCH 1/3] avdevice/xv: change codec to wrapped avframe

2020-04-06 Thread Nicolas George
Carl Eugen Hoyos (12020-04-06): > Thank you, I had never realized this in all the years I (thought I) had > to specify --enable-decoder=rawvideo,wrapped_avframe... I am not sure exactly what you are saying. You would need the corresponding encoder, of course, whatever it is. And if it's not the de

Re: [FFmpeg-devel] [PATCH 1/3] avdevice/xv: change codec to wrapped avframe

2020-04-06 Thread Carl Eugen Hoyos
Am Mo., 6. Apr. 2020 um 19:58 Uhr schrieb Nicolas George : > > Carl Eugen Hoyos (12020-04-06): > > Is it possible to support both codecs? > > Of course it it possible. And this is exactly the right thing to do > (modulo the question of which raw frame API we keep). > > > Commit 64ceeac2 changed the

Re: [FFmpeg-devel] [PATCH 1/3] avdevice/xv: change codec to wrapped avframe

2020-04-06 Thread Nicolas George
Marton Balint (12020-04-06): > avdevice/xv and avdevice/opengl are rarely used outside of ffmpeg CLI > invocations, so I don't think it is worth supporting the inferior rawvideo. They are used. > If you feel strongly about this then let's drop rawvideo support after the > API bump. No, let's kee

Re: [FFmpeg-devel] [PATCH 1/3] avdevice/xv: change codec to wrapped avframe

2020-04-06 Thread Marton Balint
On Mon, 6 Apr 2020, Nicolas George wrote: Marton Balint (12020-04-06): Signed-off-by: Marton Balint --- libavdevice/xv.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) Thanks for working on this. Adding support for the more efficient API is a good idea. On the ot

Re: [FFmpeg-devel] [PATCH 1/3] avdevice/xv: change codec to wrapped avframe

2020-04-06 Thread Nicolas George
Carl Eugen Hoyos (12020-04-06): > Is it possible to support both codecs? Of course it it possible. And this is exactly the right thing to do (modulo the question of which raw frame API we keep). > Commit 64ceeac2 changed the only supported format for the > null muxer without any version bump. > (

Re: [FFmpeg-devel] [PATCH 1/3] avdevice/xv: change codec to wrapped avframe

2020-04-06 Thread Carl Eugen Hoyos
Am Mo., 6. Apr. 2020 um 16:39 Uhr schrieb Nicolas George : > > Carl Eugen Hoyos (12020-04-06): > > We have done that in the past (for output formats that are not > > testing-only as xv). > > Xv is not testing only. OpenGL even less. This would be > breaking actual features. Is it possible to suppo

Re: [FFmpeg-devel] [PATCH 1/3] avdevice/xv: change codec to wrapped avframe

2020-04-06 Thread Nicolas George
Carl Eugen Hoyos (12020-04-06): > We have done that in the past (for output formats that are not > testing-only as xv). Xv is not testing only. OpenGL even less. This would be breaking actual features. What formats are you thinking of? Even if we did, it is entirely possible we were wrong then. R

Re: [FFmpeg-devel] [PATCH 1/3] avdevice/xv: change codec to wrapped avframe

2020-04-06 Thread Carl Eugen Hoyos
Am Mo., 6. Apr. 2020 um 14:31 Uhr schrieb Nicolas George : > > Marton Balint (12020-04-06): > > Signed-off-by: Marton Balint > > --- > > libavdevice/xv.c | 15 +-- > > 1 file changed, 5 insertions(+), 10 deletions(-) > > Thanks for working on this. > > Adding support for the more effi

Re: [FFmpeg-devel] [PATCH 1/3] avdevice/xv: change codec to wrapped avframe

2020-04-06 Thread Nicolas George
Marton Balint (12020-04-06): > Signed-off-by: Marton Balint > --- > libavdevice/xv.c | 15 +-- > 1 file changed, 5 insertions(+), 10 deletions(-) Thanks for working on this. Adding support for the more efficient API is a good idea. On the other hand, if applications use this device

[FFmpeg-devel] [PATCH 1/3] avdevice/xv: change codec to wrapped avframe

2020-04-05 Thread Marton Balint
Signed-off-by: Marton Balint --- libavdevice/xv.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/libavdevice/xv.c b/libavdevice/xv.c index c3ed2e48bd..2c5f1a4432 100644 --- a/libavdevice/xv.c +++ b/libavdevice/xv.c @@ -113,8 +113,8 @@ static int xv_write_head