Re: [FFmpeg-devel] [PATCH 1/3] avcodec/nvenc: Fix b-frame parameter handling

2015-01-25 Thread Michael Niedermayer
On Sun, Jan 25, 2015 at 10:28:22AM +0100, Timo Rothenpieler wrote: > >> +/* 0 is intra-only, 1 is I/P only, 2 is one B Frame, 3 two B frames, > >> and so on. */ > >> +ctx->encode_config.frameIntervalP = avctx->max_b_frames + 1; > > > > how can the user choose between intra only and IP ? >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/nvenc: Fix b-frame parameter handling

2015-01-25 Thread Timo Rothenpieler
>> +/* 0 is intra-only, 1 is I/P only, 2 is one B Frame, 3 two B frames, >> and so on. */ >> +ctx->encode_config.frameIntervalP = avctx->max_b_frames + 1; > > how can the user choose between intra only and IP ? > > i would have assumed that gop_size <= 1 would select intra only > max_b

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/nvenc: Fix b-frame parameter handling

2015-01-22 Thread Michael Niedermayer
On Fri, Jan 16, 2015 at 01:02:38AM +0100, Timo Rothenpieler wrote: > --- > libavcodec/nvenc.c | 20 > 1 file changed, 8 insertions(+), 12 deletions(-) > > diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c > index 5cd7727..90856be 100644 > --- a/libavcodec/nvenc.c > +++ b/l

[FFmpeg-devel] [PATCH 1/3] avcodec/nvenc: Fix b-frame parameter handling

2015-01-15 Thread Timo Rothenpieler
--- libavcodec/nvenc.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 5cd7727..90856be 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -155,7 +155,6 @@ typedef struct NvencContext char *preset