Re: [FFmpeg-devel] [PATCH 1/3] avcodec/av1dec: Fix leak in case of failure

2020-12-04 Thread James Almer
On 12/4/2020 8:19 PM, Andreas Rheinhardt wrote: James Almer: On 12/4/2020 7:57 PM, Andreas Rheinhardt wrote: A reference to an AV1RawFrameHeader and consequently the AV1RawFrameHeader itself and everything it has a reference to leak if the hardware has no AV1 decoding capabilities. It looks l

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/av1dec: Fix leak in case of failure

2020-12-04 Thread Andreas Rheinhardt
James Almer: > On 12/4/2020 7:57 PM, Andreas Rheinhardt wrote: >> A reference to an AV1RawFrameHeader and consequently the >> AV1RawFrameHeader itself and everything it has a reference to leak >> if the hardware has no AV1 decoding capabilities. > > It looks like it can happen if get_buffer() fail

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/av1dec: Fix leak in case of failure

2020-12-04 Thread James Almer
On 12/4/2020 7:57 PM, Andreas Rheinhardt wrote: A reference to an AV1RawFrameHeader and consequently the AV1RawFrameHeader itself and everything it has a reference to leak if the hardware has no AV1 decoding capabilities. It looks like it can happen if get_buffer() fails even with hardware sup

[FFmpeg-devel] [PATCH 1/3] avcodec/av1dec: Fix leak in case of failure

2020-12-04 Thread Andreas Rheinhardt
A reference to an AV1RawFrameHeader and consequently the AV1RawFrameHeader itself and everything it has a reference to leak if the hardware has no AV1 decoding capabilities. It happens e.g. in the cbs-av1-av1-1-b8-02-allintra FATE-test; it has just been masked because the return value of ffmpeg (wh