Re: [FFmpeg-devel] [PATCH 1/3] avcodec/alsdec: Limit maximum channels to 64

2019-08-20 Thread Michael Niedermayer
On Tue, Aug 20, 2019 at 09:12:36AM +0200, Thilo Borgmann wrote: > Am 19.08.19 um 23:22 schrieb Michael Niedermayer: > > On Mon, Aug 19, 2019 at 05:09:37PM +0200, Thilo Borgmann wrote: > >> Am 19.08.19 um 14:27 schrieb Michael Niedermayer: > >>> On Mon, Aug 19, 2019 at 07:41:43AM +0200, Thilo Borgma

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/alsdec: Limit maximum channels to 64

2019-08-20 Thread Thilo Borgmann
Am 19.08.19 um 23:22 schrieb Michael Niedermayer: > On Mon, Aug 19, 2019 at 05:09:37PM +0200, Thilo Borgmann wrote: >> Am 19.08.19 um 14:27 schrieb Michael Niedermayer: >>> On Mon, Aug 19, 2019 at 07:41:43AM +0200, Thilo Borgmann wrote: Am 19.08.19 um 01:30 schrieb Michael Niedermayer: > T

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/alsdec: Limit maximum channels to 64

2019-08-19 Thread Michael Niedermayer
On Mon, Aug 19, 2019 at 05:09:37PM +0200, Thilo Borgmann wrote: > Am 19.08.19 um 14:27 schrieb Michael Niedermayer: > > On Mon, Aug 19, 2019 at 07:41:43AM +0200, Thilo Borgmann wrote: > >> Am 19.08.19 um 01:30 schrieb Michael Niedermayer: > >>> There seems to be no limit in the specification and up

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/alsdec: Limit maximum channels to 64

2019-08-19 Thread Thilo Borgmann
Am 19.08.19 um 14:27 schrieb Michael Niedermayer: > On Mon, Aug 19, 2019 at 07:41:43AM +0200, Thilo Borgmann wrote: >> Am 19.08.19 um 01:30 schrieb Michael Niedermayer: >>> There seems to be no limit in the specification and upto 64k could be stored >>> 64 is chooses as limit as thats also used for

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/alsdec: Limit maximum channels to 64

2019-08-19 Thread Michael Niedermayer
On Mon, Aug 19, 2019 at 07:41:43AM +0200, Thilo Borgmann wrote: > Am 19.08.19 um 01:30 schrieb Michael Niedermayer: > > There seems to be no limit in the specification and upto 64k could be stored > > 64 is chooses as limit as thats also used for AAC and is what a int64 mask > > can handle > > > >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/alsdec: Limit maximum channels to 64

2019-08-19 Thread Michael Niedermayer
On Mon, Aug 19, 2019 at 07:41:43AM +0200, Thilo Borgmann wrote: > Am 19.08.19 um 01:30 schrieb Michael Niedermayer: > > There seems to be no limit in the specification and upto 64k could be stored > > 64 is chooses as limit as thats also used for AAC and is what a int64 mask > > can handle > > > >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/alsdec: Limit maximum channels to 64

2019-08-18 Thread Thilo Borgmann
Am 19.08.19 um 01:30 schrieb Michael Niedermayer: > There seems to be no limit in the specification and upto 64k could be stored > 64 is chooses as limit as thats also used for AAC and is what a int64 mask > can handle > > An alternative to this patch would be a max_channels variable There's a co

[FFmpeg-devel] [PATCH 1/3] avcodec/alsdec: Limit maximum channels to 64

2019-08-18 Thread Michael Niedermayer
There seems to be no limit in the specification and upto 64k could be stored 64 is chooses as limit as thats also used for AAC and is what a int64 mask can handle An alternative to this patch would be a max_channels variable Fixes: OOM Fixes: 16200/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_